Opened 8 years ago
Closed 8 years ago
#3855 closed Bug (fixed)
use unminified _source files for plugins
| Reported by: | Dave Schoorl | Owned by: | Garry Yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.1 |
| Component: | General | Version: | 3.0 RC |
| Keywords: | Confirmed Review+ | Cc: |
Description
I would like to run CKEditor completely with unminified code, so it is easier to see what is going on and allow for useful debugging with Firebug. This can partially be done by including the javascript file /ckeditor/ckeditor_source.js. However, only the core files are loaded unminified from /ckeditor/_source/core, all other files are loaded minified. E.g. plugin dialog files are minified and loaded from /ckeditor/plugins/ and not from /ckeditor/_source/plugins.
It would be very helpful if the plugin files could be unminified as well and get loaded from /ckeditor/_source/plugins.
I am new to (F)CKEditor, so maybe I am missing something.
P.S. setting the global variable CKEDITOR_BASEPATH to /ckeditor/_source/ results in the core files not being found.
Attachments (3)
Change History (15)
comment:1 Changed 8 years ago by
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
comment:2 Changed 8 years ago by
| Resolution: | invalid |
|---|---|
| Status: | closed → reopened |
Are you saying that this feature is added in the trunk? Do I need to do anything special to work with unminified plugin sources?
comment:3 Changed 8 years ago by
| Resolution: | → invalid |
|---|---|
| Status: | reopened → closed |
No, this is not a feature, code in SVN is "unminified" because "it is easier to see what is going on and allow for useful debugging with Firebug"
comment:4 Changed 8 years ago by
| Keywords: | Confirmed added |
|---|---|
| Milestone: | → CKEditor 3.1 |
| Resolution: | invalid |
| Status: | closed → reopened |
Considering the the source version of the plugins are in the package, we should really try loading them instead.
Let's check if it's doable after the 3.0.
Changed 8 years ago by
| Attachment: | 3855.patch added |
|---|
comment:5 Changed 8 years ago by
| Keywords: | Review? added |
|---|---|
| Owner: | set to Garry Yao |
| Status: | reopened → new |
| Type: | New Feature → Bug |
I'm wondering if this's actually a bug which was left there...
comment:6 Changed 8 years ago by
| Keywords: | Review- added; Review? removed |
|---|
No, %REMOVE_LINE% is the right thing to have there. Your change is now forcing the editor to "always" load plugins from source.
We need a more generic solution that could work for plugins, skins, themes, etc.
comment:7 Changed 8 years ago by
Review- but just just because we should also load skins, themes and language files from the source folder.
The fix looks good, this line should be removed by CKPackager, not CKReleaser.
Changed 8 years ago by
| Attachment: | 3855_2.patch added |
|---|
comment:8 Changed 8 years ago by
| Keywords: | Review? added; Review- removed |
|---|---|
| Status: | new → assigned |
Pending all other packaged files.
comment:9 Changed 8 years ago by
| Keywords: | Review- added; Review? removed |
|---|
Almost good, it turned out that there is one more extra thing to fix: the uicolor plugin.
Changed 8 years ago by
| Attachment: | 3855_3.patch added |
|---|
comment:10 Changed 8 years ago by
| Keywords: | Review? added; Review- removed |
|---|
3855_3.patch is basically the same as 3855_2.patch, one more fix for the uicolor plugin has been added.
comment:11 Changed 8 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
You can use our development version: http://dev.fckeditor.net/wiki/SVN but we don't recommend using this version on real site.
For support please use our forums: http://www.fckeditor.net/forums/