Opened 8 years ago

Closed 8 years ago

#3856 closed Bug (fixed)

Pressing the source toolbar button doesn't focus right

Reported by: jmraker Owned by: Tobiasz Cudnik
Priority: Normal Milestone: CKEditor 3.1
Component: General Version:
Keywords: Confirmed Review+ Cc:

Description

http://ecgdev.com/ajax1/test.html

Actual results in firefox: When I press the edit source button in the toolbar, the blur event is called and the focus event isn't called again until the editor is out of "edit source" mode. On focus the CKEditor should have a blue box around it. On blur it's gone. When clicking on the "edit source" button the blue border is gone after 1 or more clicks (usually one). When it's in "edit source" mode the border doesn't come back no matter where I click in the editor.

Actual results in IE8: The problem is reversed, where the editor's border stays blue and doesn't go away until it's out of edit source mode.

Expected results: The editor should call the focus/blur events in edit source mode so the editor's border is blue when focused, and not blue when not focused.

http://ecgdev.com/ajax1/test.html

Attachments (1)

3856.patch (2.2 KB) - added by Tobiasz Cudnik 8 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 8 years ago by jmraker

Milestone: CKEditor 3.xCKEditor 3.0

comment:2 Changed 8 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.0CKEditor 3.1

comment:3 Changed 8 years ago by Tobiasz Cudnik

Keywords: Confirmed added
Owner: set to Tobiasz Cudnik
Status: newassigned

Changed 8 years ago by Tobiasz Cudnik

Attachment: 3856.patch added

comment:4 Changed 8 years ago by Tobiasz Cudnik

Keywords: Review? added

Patch adds focus and blur events to source area mode. Additionally it fixes same events for webkit based browsers inside wysiwyg area mode (as they were broken).

Thanks for providing a test page.

comment:5 Changed 8 years ago by Tobiasz Cudnik

Summary: ckeditor - Pressing the source toolbar button doesn't focus rightPressing the source toolbar button doesn't focus right

comment:6 Changed 8 years ago by Tobiasz Cudnik

#3996 has been marked as a DUP.

comment:7 Changed 8 years ago by Garry Yao

Keywords: Review+ added; Review? removed

Ticket Test added at : http://ckeditor.t/tt/3856/1.html.

comment:8 Changed 8 years ago by Tobiasz Cudnik

Resolution: fixed
Status: assignedclosed

Fixed with [4172].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy