Opened 15 years ago
Closed 15 years ago
#4041 closed Bug (fixed)
[IE] Remove multiple rows doesn't work
Reported by: | Garry Yao | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.1 |
Component: | Core : Styles | Version: | |
Keywords: | IE Confirmed Review+ | Cc: |
Description
Reproducing Procedures
- Open the 'replace by class' sample page.
- Load the document with following content and selection:
<table> <tbody> <tr> <td> [row1</td> </tr> <tr> <td> row2]</td> </tr> </tbody> </table>
- Open context menu and 'row' submenu, click 'Delete Rows'.
- Actual Result: Only row2 get deleted.
Attachments (4)
Change History (21)
comment:1 Changed 15 years ago by
Milestone: | CKEditor 3.0 → CKEditor 3.1 |
---|
comment:2 Changed 15 years ago by
Owner: | set to Garry Yao |
---|---|
Status: | new → assigned |
comment:3 Changed 15 years ago by
Keywords: | Confirmed added |
---|
Changed 15 years ago by
Attachment: | 4041.patch added |
---|
comment:4 Changed 15 years ago by
Keywords: | Review? added |
---|
comment:5 Changed 15 years ago by
Keywords: | Review- added; Review? removed |
---|
Changed 15 years ago by
Attachment: | 4041_2.patch added |
---|
comment:6 Changed 15 years ago by
Keywords: | Review? added; Review- removed |
---|
Find an alternative solution for it without any draw backs.
comment:8 Changed 15 years ago by
Keywords: | Review- added; Review? removed |
---|
The proposed patch will not work withe the following selection case:
<table> <tbody> <tr> <td> <strong>r[ow1</strong></td> </tr> <tr> <td> <strong>row]2</strong></td> </tr> </tbody> </table>
Changed 15 years ago by
Attachment: | 4041_3.patch added |
---|
comment:10 follow-up: 12 Changed 15 years ago by
Keywords: | Review? added; Review- removed |
---|
Note that it's even not an ultimate solution, actually the issue is not limited to only 'table element', instead all elements that been displayed as control type is effected including but not limited to the following:
- Floated block. See #3670
- Sized block. e.g. <p style="width:300px">paragraph</p>
After closed this ticket, we should investigate on the proper way to enumerate/determinate this kind of elements for handling them in a similar manner with this case.
comment:12 Changed 15 years ago by
comment:13 Changed 15 years ago by
Keywords: | Review- added; Review? removed |
---|
The patch is got... there is a minor improvement we could have on it. The "target" variable is not anymore needed. In fact, by moving evt.data.getTarget() inside the if check, we avoid executing it if the button is different of "2".
The R+ will come immediately after this small change.
Changed 15 years ago by
Attachment: | 4041_4.patch added |
---|
comment:14 Changed 15 years ago by
Keywords: | Review? added; Review- removed |
---|
comment:15 Changed 15 years ago by
Keywords: | Review+ added; Review? removed |
---|
comment:17 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
I'm having an undesired effect after the patch. The prooblem is that the selection is "always" restored in the editor, even if I'm clicking out of it to close the context menu. TC: