#4067 closed New Feature (fixed)
Fullpage support
| Reported by: | Garry Yao | Owned by: | Frederico Caldeira Knabben |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.1 |
| Component: | Core : Output Data | Version: | |
| Keywords: | Confirmed Review+ | Cc: |
Description
The editor don't actually have full page support yet despite of the existence of fullPage config entry.
Attachments (4)
Change History (22)
comment:1 Changed 15 years ago by
| Component: | Core : Output Data → General |
|---|---|
| Keywords: | Confirmed added |
| Milestone: | CKEditor 3.0 → CKEditor 3.1 |
comment:2 Changed 15 years ago by
| Type: | Bug → New Feature |
|---|
comment:3 Changed 15 years ago by
| Owner: | set to Garry Yao |
|---|---|
| Status: | new → assigned |
Changed 15 years ago by
| Attachment: | 4067.patch added |
|---|
comment:4 Changed 15 years ago by
| Component: | General → Core : Output Data |
|---|---|
| Keywords: | Review? added |
Please note that I'll open new ticket for full page support in preview plugin as well as document property dialog, this ticket has dedicated to data I/O features.
comment:5 Changed 15 years ago by
Ticket Test added at:
http://ckeditor.t/tt/4067/1.html.
http://ckeditor.t/tt/4067/2.html.
http://ckeditor.t/tt/4067/3.html.
comment:6 Changed 15 years ago by
| Keywords: | Review- added; Review? removed |
|---|
- Filter rules related to design mode should be moved into 'wysiwyg' plugin
- 'toHtml/toDataFormat' should be editor ignorant.
Changed 15 years ago by
| Attachment: | 4067_2.patch added |
|---|
comment:7 Changed 15 years ago by
| Keywords: | Review? added; Review- removed |
|---|
comment:8 Changed 15 years ago by
| Keywords: | Review- added; Review? removed |
|---|
Let's try making this solution a bit simpler. It would be also nice to have it as a separate plugin.
Changed 15 years ago by
| Attachment: | 4067_3.patch added |
|---|
comment:9 follow-up: 10 Changed 15 years ago by
| Keywords: | Review? added; Review- removed |
|---|
Move around 200 LOC into a dedicated 'fullpage' plugin make changes to the core much smaller.
comment:10 Changed 15 years ago by
Replying to garry.yao:
Move around 200 LOC into a dedicated 'fullpage' plugin make changes to the core much smaller.
Patched the HEAD revision today with 4067_3.patch. It works, except that the editor does not load stylesheets in the <head> section (both <link rel="stylesheet" ... > and <style>...</style>).
There also seems to be a problem if the entered markup contains anything before the opening <html> tag (eg. comments, <!doctype). CKeditor fails to detect the opening <html> tag and puts everything in its own <html> and <body> tags in such case.
comment:11 Changed 15 years ago by
| Keywords: | Review- added; Review? removed |
|---|
- Typo in the wysiwyg area plugin line 18 (:?) instead of (?:).
- Please fix the spelling from $noneBodyContent to $nonBodyContent.
- We don't need an additional docType method in the basicWriter. The "write" method can be used for that.
- The fragment in fact should not really care if the document is full page or not. It must simply parse any HTML. The data processor should take care of the differences instead.
- In the wysiwyg plugin, in getData, editor.config.fullPage can be cached in a local var.
- Always in getData, there is some additional processing that's always happening, even if fullPage == false. The documentElement and docTypeAttr values are being calculated even if not needed.
- The shelveTags can be more generic use. It can be also split with the unshelveTags.
- The doctype should be handled into the fullpage plugin actually. We must try concentrating all full page stuff there.
Changed 15 years ago by
| Attachment: | 4067_4.patch added |
|---|
comment:13 Changed 15 years ago by
Checked out SVN and built it, but still not submitting the whole page. There is a DOCTYPE on the page. config.fullPage = true; is in the config. I'll try the nightly tomorrow.
comment:15 Changed 15 years ago by
| Keywords: | Review? added; Review- removed |
|---|---|
| Owner: | changed from Garry Yao to Frederico Caldeira Knabben |
| Status: | assigned → new |
I've opened a feature branch for this feature:
http://svn.fckeditor.net/CKEditor/branches/features/fullpage/
This setting is still not active.