Opened 9 years ago

Closed 8 years ago

#4174 closed Bug (fixed)

IE : Dialogs may have scrollbars

Reported by: Frederico Caldeira Knabben Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.1
Component: UI : Dialogs Version: SVN (CKEditor) - OLD
Keywords: Confirmed IE Review? Cc:

Description

In IE, we may have dialogs with scrollbars in some languages due to the size of the translated labels. #4128 is an example.

We've proposed a workaround for other browser at #3878, but IE is still missing.

Attachments (2)

4174.patch (6.1 KB) - added by Garry Yao 9 years ago.
4174_2.patch (4.5 KB) - added by Garry Yao 8 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 9 years ago by Garry Yao

Owner: set to Garry Yao
Status: newassigned

comment:2 Changed 9 years ago by Garry Yao

Priority: NormalHigh

Changed 9 years ago by Garry Yao

Attachment: 4174.patch added

comment:3 Changed 9 years ago by Garry Yao

Keywords: Review? added

comment:4 Changed 9 years ago by Frederico Caldeira Knabben

Priority: HighNormal

comment:5 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

We need to make it simple, and these fixes for the dialog system issues are starting to make other parts of the code dirty. Let's take the easy approach for now, and then definitely fix it when reviewing the dialog system.

Our main problem here is the image dialog. I would instead propose making changes in the dialog to uniformize it to the standards, having the fields title above them, instead of at the left. In this way we correct two things at the same time.

Changed 8 years ago by Garry Yao

Attachment: 4174_2.patch added

comment:6 Changed 8 years ago by Garry Yao

Keywords: Review? added; Review- removed

Apply layout adjustments to those dialogs which have the risk of overflow.

comment:7 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

As discussed on #4521, we could simply close this ticket now without any patch made here.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy