Opened 8 years ago

Closed 7 years ago

#4231 closed New Feature (fixed)

Vertical only resize

Reported by: mike890 Owned by: Alfonso Martínez de Lizarrondo
Priority: Normal Milestone: CKEditor 3.3
Component: General Version: 3.0
Keywords: Confirmed Review+ Cc:

Description

In many cases it is necessary to have vertical only resize with 100% width of the editor. The current resize addin does not support this configuration.

See more about this feature @ http://www.fckeditor.net/forums/viewtopic.php?f=11&t=15334

Attachments (3)

4231.patch (1.4 KB) - added by Alfonso Martínez de Lizarrondo 7 years ago.
Proposed patch
4231_2.patch (2.4 KB) - added by Alfonso Martínez de Lizarrondo 7 years ago.
Revised patch
4231_3.patch (5.1 KB) - added by Alfonso Martínez de Lizarrondo 7 years ago.
Revised patch

Download all attachments as: .zip

Change History (17)

comment:1 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Confirmed added
Milestone: CKEditor 3.1

comment:2 Changed 8 years ago by Brandon Kelly

I suggest making this setting accept two values: 'x' and 'y' rather than just a restrict-to-vertical flag. Maybe call it 'resize_restrictToAxis' or something.

comment:3 Changed 8 years ago by Garry Yao

Milestone: CKEditor 3.1CKEditor 3.2
Version: SVN (CKEditor)

comment:4 Changed 8 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.2CKEditor 3.3

Changed 7 years ago by Alfonso Martínez de Lizarrondo

Attachment: 4231.patch added

Proposed patch

comment:5 Changed 7 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review? added
Owner: set to Alfonso Martínez de Lizarrondo
Status: newassigned
Version: SVN (CKEditor)3.0

The patch checks if the min and width have the same value and in that case ignores the changes of the resizer for that dimension.

comment:6 Changed 7 years ago by Garry Yao

Keywords: Review- added; Review? removed

I don't think this's the best way for such feature, will two extra one-dimension resize handler be a better choice?

comment:7 Changed 7 years ago by Garry Yao

At least we should have separate config entries for them.

comment:8 Changed 7 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review? added; Review- removed

I see that I wrote the description wrong.

The patch checks if min and max values for a dimension have the same values, that means that the user doesn't want that dimension bigger or smaller that such value, and in that case that dimension isn't resized.

So without any extra config entries it's possible to disable the vertical or horizontal resize.

comment:9 Changed 7 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

We need a dedicated setting for it. The fact is that, by default, users don't know what are the min and max values... in fact they don't care about the width at all, having the default values as good. They just want to have the editor resizable vertically only. We also have percent widths just to make things more complex.

Let's make it simpler for us and for our users: config.resize_dir = "both|vertical". We could have it also "horizontal" if it's easy to have, but that's not a priority.

Changed 7 years ago by Alfonso Martínez de Lizarrondo

Attachment: 4231_2.patch added

Revised patch

comment:10 Changed 7 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review? added; Review- removed

The new patch introduces such config setting, as well as the previous system of automatically disabling resizing if max==min

comment:11 Changed 7 years ago by Garry Yao

Keywords: Review- added; Review? removed

Almost there, we need a skin change to indicate the direction with different cursor type (s-resize and e-resize) also.

Changed 7 years ago by Alfonso Martínez de Lizarrondo

Attachment: 4231_3.patch added

Revised patch

comment:12 Changed 7 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review? added; Review- removed

Cursor adjusted in new patch.

I've filed #5644 to provide new pictures for the grabber and place it in the middle of the bottom bar (or right side) for vertical or horizontal only resize.

comment:13 Changed 7 years ago by Garry Yao

Keywords: Review+ added; Review? removed

comment:14 Changed 7 years ago by Alfonso Martínez de Lizarrondo

Resolution: fixed
Status: assignedclosed

Fixed with [5478]

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy