Opened 16 years ago
Closed 15 years ago
#4231 closed New Feature (fixed)
Vertical only resize
Reported by: | mike890 | Owned by: | Alfonso Martínez de Lizarrondo |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.3 |
Component: | General | Version: | 3.0 |
Keywords: | Confirmed Review+ | Cc: |
Description
In many cases it is necessary to have vertical only resize with 100% width of the editor. The current resize addin does not support this configuration.
See more about this feature @ http://www.fckeditor.net/forums/viewtopic.php?f=11&t=15334
Attachments (3)
Change History (17)
comment:1 Changed 16 years ago by
Keywords: | Confirmed added |
---|---|
Milestone: | → CKEditor 3.1 |
comment:2 Changed 16 years ago by
comment:3 Changed 15 years ago by
Milestone: | CKEditor 3.1 → CKEditor 3.2 |
---|---|
Version: | → SVN (CKEditor) |
comment:4 Changed 15 years ago by
Milestone: | CKEditor 3.2 → CKEditor 3.3 |
---|
comment:5 Changed 15 years ago by
Keywords: | Review? added |
---|---|
Owner: | set to Alfonso Martínez de Lizarrondo |
Status: | new → assigned |
Version: | SVN (CKEditor) → 3.0 |
The patch checks if the min and width have the same value and in that case ignores the changes of the resizer for that dimension.
comment:6 Changed 15 years ago by
Keywords: | Review- added; Review? removed |
---|
I don't think this's the best way for such feature, will two extra one-dimension resize handler be a better choice?
comment:8 Changed 15 years ago by
Keywords: | Review? added; Review- removed |
---|
I see that I wrote the description wrong.
The patch checks if min and max values for a dimension have the same values, that means that the user doesn't want that dimension bigger or smaller that such value, and in that case that dimension isn't resized.
So without any extra config entries it's possible to disable the vertical or horizontal resize.
comment:9 Changed 15 years ago by
Keywords: | Review- added; Review? removed |
---|
We need a dedicated setting for it. The fact is that, by default, users don't know what are the min and max values... in fact they don't care about the width at all, having the default values as good. They just want to have the editor resizable vertically only. We also have percent widths just to make things more complex.
Let's make it simpler for us and for our users: config.resize_dir = "both|vertical". We could have it also "horizontal" if it's easy to have, but that's not a priority.
comment:10 Changed 15 years ago by
Keywords: | Review? added; Review- removed |
---|
The new patch introduces such config setting, as well as the previous system of automatically disabling resizing if max==min
comment:11 Changed 15 years ago by
Keywords: | Review- added; Review? removed |
---|
Almost there, we need a skin change to indicate the direction with different cursor type (s-resize and e-resize) also.
comment:12 Changed 15 years ago by
Keywords: | Review? added; Review- removed |
---|
Cursor adjusted in new patch.
I've filed #5644 to provide new pictures for the grabber and place it in the middle of the bottom bar (or right side) for vertical or horizontal only resize.
comment:13 Changed 15 years ago by
Keywords: | Review+ added; Review? removed |
---|
I suggest making this setting accept two values: 'x' and 'y' rather than just a restrict-to-vertical flag. Maybe call it 'resize_restrictToAxis' or something.