Opened 8 years ago

Closed 8 years ago

#4673 closed Bug (fixed)

Undo not available straight away if shift key is used to enter first character.

Reported by: Joe Kavanagh Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.1
Component: Core : Undo & Redo Version: SVN (CKEditor) - OLD
Keywords: IBM Confirmed Review+ Cc: dchojna@…

Description

When entering some text into the editor use the shift key to capitalize the first character. Observe that the Undo button is not active until about 15 characters have been entered.

Attachments (3)

4673.patch (2.7 KB) - added by Garry Yao 8 years ago.
4673_2.patch (2.7 KB) - added by Garry Yao 8 years ago.
4673_3.patch (1.2 KB) - added by Garry Yao 8 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 8 years ago by Garry Yao

Keywords: Confirmed added
Owner: set to Garry Yao
Status: newassigned
Version: 3.0.1SVN (CKEditor)

Nice catch, this's something that definitely need to fix right now.

Changed 8 years ago by Garry Yao

Attachment: 4673.patch added

comment:2 Changed 8 years ago by Garry Yao

Update key map of editing keys, modifier keys and navigation keys according to: keyboard keys

comment:3 Changed 8 years ago by Garry Yao

Keywords: Review? added

comment:4 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

Please remove the space and tab keys from the editing list as having snapshots for each space reduces the undo stack too much, considering that it's a very very common key (the most common).

Changed 8 years ago by Garry Yao

Attachment: 4673_2.patch added

comment:5 Changed 8 years ago by Garry Yao

Keywords: Review? added; Review- removed

comment:6 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:7 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [4607].

comment:8 Changed 8 years ago by Damian

Resolution: fixed
Status: closedreopened

This is still reproducible, although the steps to reproduce are slightly different.

  1. Use Ajax sample.
  2. Create editor and focus into body.
  3. Press CAPS Lock once. (This means toggle once, it does not matter if it is on or off)
  4. Type into the editor.

Notice that undo does not activate.

Reproduced on FF 3.5 & IE 7

Changed 8 years ago by Garry Yao

Attachment: 4673_3.patch added

comment:9 Changed 8 years ago by Garry Yao

Keywords: Review? added; Review+ removed

comment:10 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:11 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: reopenedclosed

Fixed with [4817].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy