Opened 10 years ago

Closed 7 years ago

#4979 closed Bug (expired)

Ensure all source files are in _source directory

Reported by: AlexC Owned by:
Priority: Normal Milestone:
Component: General Version: 3.0
Keywords: Discussion Cc:

Description

I'm not sure if this is intentional/required - however it makes sense to me to have the following files in the '_source' directory, since they are source files.

ckeditor_basic_source.js ckeditor_source.js ckeditor.pack (would obviously require changes within for the paths)

It just makes it easier to manage all source files, as I wont be including these source files in my projects package - deleting just 1 directory is easier.

Change History (6)

comment:1 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Confirmed added
Milestone: CKEditor 3.3
Version: 3.13.0

This definitely makes sense. We must just check if it's feasible, considering the current structure.

Even moving the ckeditor.pack file makes sense, as it's totally dependent on the _source files.

comment:2 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Discussion added; Confirmed removed

I'm just afraid it may be already too late for these kinds of changes. People may already be using the current paths their on applications and documentation.

comment:3 Changed 10 years ago by Alfonso Martínez de Lizarrondo

Moving the ckeditor.pack to _source might be correct as it's used only for repackaging the source, but I think that ckeditor_basic_source.js and ckeditor_source.js should stay at that location, only for the fact that this way it's easier for the people to realize that they can easily use the _source files by switching to those files.

Anyway, there are other files at the root folder that I guess that you won't distribute in your app like CHANGES.html, INSTALL.html or the .php helpers and any other server script that might be added in the future, so you'll always need to manually clean up the root folder. Also you might want to clean the plugins folder removing the dialogs of plugins that you don't use, so the overall point of moving ckeditor_basic_source.js and ckeditor_source.js is moot.

comment:4 Changed 10 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.3CKEditor 3.x

I'm also tending to give a -1 to this change. It's not really a big issue for now.

Let's wait and see what others think about it.

comment:5 Changed 9 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.x

Milestone CKEditor 3.x deleted

comment:6 Changed 7 years ago by Piotrek Koszuliński

Resolution: expired
Status: newclosed

In 4.0 we changed the structure and I think that it is good. I'm closing this issue as expired.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy