Opened 15 years ago
Closed 14 years ago
#5237 closed Bug (fixed)
English text in dialogs' title is flipped when using RTL language
Reported by: | Sa'ar Zac Elias | Owned by: | Sa'ar Zac Elias |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.4.2 |
Component: | UI : Language | Version: | 3.1 |
Keywords: | IE | Cc: |
Description
To reproduce
- Go to the demo and open the multi language interface.
- Choose RTL language (i.e Hebrew)
- Click on the 'Help' button for example.
Notice that the product name in the dialog title is flipped.
Attachments (3)
Change History (20)
comment:1 follow-up: 10 Changed 15 years ago by
Component: | General → UI : Language |
---|---|
Keywords: | Confirmed IE added |
Milestone: | → CKEditor 3.3 |
comment:2 follow-up: 3 Changed 15 years ago by
Umm, SCAYT plugin for example.
I have recently translated everything and you applied it to the 3.2 version, so after this release i'll have a better look on that one.
Anyway, i think it should be fixed in the CSS for further compatibility
comment:3 Changed 15 years ago by
Replying to Saare:
Anyway, i think it should be fixed in the CSS for further compatibility
I think so also... but really I remember we've spent a lot of time on this issue. If I recall it well it was breaking the dialog dragging in the title area with IE.
comment:4 Changed 15 years ago by
OK, in Hebrew the problem is in all the SCAYT dialog (btw is there a way to translate the options inside of them?), Div container and About dialog.
comment:6 Changed 15 years ago by
Replying to Saare:
Oh, and the new 'Accessibility instructions' dialog.
Isn't it translatable? I mean, do you leave it in English for the Hebrew language?
comment:7 Changed 15 years ago by
Oops.. yes, i'll also translate this plugin with all the other language phrases that are to be translated, targeted to the 3.3 version release.
Anyway, if the problem is with the dragging, maybe if you cover the dialog title with a transparent DIV it will work OK.
Changed 15 years ago by
Attachment: | 5237.patch added |
---|
comment:9 Changed 15 years ago by
Keywords: | Pending added; Confirmed removed |
---|
I'm curious which browser do you have this reproduced? WFM in both IE7 and IE8.
comment:10 Changed 15 years ago by
IE8. If you check this bug with Arabic in About dialog you will not observe this issue, as Fred wrote.
Changed 15 years ago by
Attachment: | 5237_2.patch added |
---|
comment:11 Changed 15 years ago by
Keywords: | Confirmed Review? added; Pending removed |
---|---|
Owner: | set to Garry Yao |
Status: | new → assigned |
but really I remember we've spent a lot of time on this issue. If I recall it well it was breaking >the dialog dragging in the title area with IE.
WFM in all IEs, I would revert the original hacks unless it's proved to be necessary.
comment:12 Changed 15 years ago by
Keywords: | Review+ added; Review? removed |
---|
Much probably, the old hack is not anymore necessary because of the recent dialog structure changes.
comment:14 Changed 14 years ago by
Keywords: | Confirmed Review+ removed |
---|---|
Milestone: | CKEditor 3.3 → CKEditor 3.4.2 |
Resolution: | fixed |
Status: | closed → reopened |
The same fix must be ported to other skins as well.
Changed 14 years ago by
Attachment: | 5237_3.patch added |
---|
comment:15 Changed 14 years ago by
Owner: | changed from Garry Yao to Sa'ar Zac Elias |
---|---|
Status: | reopened → review |
comment:16 Changed 14 years ago by
Status: | review → review_passed |
---|
comment:17 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed with [5897].
Confirmed with IE only.
We had issues with CSS in IE and because of this we were forced to make some "weird" things with dialog titles (weird solutions for weird browsers!). Because of this, ltr words are reverted.
We have solved this problem in the About dialog. In fact you can see that it works well for the Arabic language.
To make it work with Hebrew, it's enough to change the following entry in the about section of the language file:
But ok, this fixes the About dialog. Do you see any other dialog that needs fixes?