Opened 8 years ago

Closed 6 years ago

#5239 closed Bug (fixed)

Behaviour of Menus in Toolbar is Inconsistent

Reported by: Satya Minnekanti Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.6.1
Component: UI : Toolbar Version: 3.1
Keywords: IBM Cc: Damian, joek

Description

To reproduce the defect

For any Menu like Font Name, Font Size,Text Colour,Background Colour, Styles or Paragraph Format when we press Esc the Menu is closed and the Focus stays on the same Menu in the Toolbar

But for Spell Check as You Type Menu when we press Esc the Menu is closed and the Focus is going in to the body of the Editor.

Attachments (1)

5239.patch (421 bytes) - added by Garry Yao 6 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 8 years ago by Frederico Caldeira Knabben

Component: GeneralUI : Toolbar
Keywords: Confirmed added
Milestone: CKEditor 3.x

comment:2 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.x

Milestone CKEditor 3.x deleted

comment:3 Changed 7 years ago by Damian

We need to revisit this ticket.

We should have consistent behaviour of core UI components like the menu button. We use the menu button for features other than spell check.

comment:4 Changed 6 years ago by Garry Yao

Cc: damo,joekdamo, joek
Component: UI : ToolbarUI : Spell Checker

#6247 has fixed the generic focus returning logic, the rest to do is to update the focus management in SCAYT plugin.

Changed 6 years ago by Garry Yao

Attachment: 5239.patch added

comment:5 Changed 6 years ago by Garry Yao

Owner: set to Garry Yao
Status: confirmedreview

Oops, SCAYT is not the one to blame as there's still a legacy focus manipulation in menu plugin.

comment:6 Changed 6 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

comment:7 Changed 6 years ago by Frederico Caldeira Knabben

Component: UI : Spell CheckerUI : Toolbar
Milestone: CKEditor 3.6.1

comment:8 Changed 6 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [6927].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy