Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#5453 closed Bug (invalid)

link plugin is missing dependency of htmldataprocessor

Reported by: Scott González Owned by:
Priority: Normal Milestone:
Component: General Version: 3.0.1
Keywords: Cc:

Description

The link plugin requires the htmldataprocessor plugin in order to properly create links, but the link plugin does not list the htmldataprocessor plugin as a dependency.

If you load the link plugin, but not the htmldataprocessor plugin, you will still see the behavior reported in #3928.

Change History (4)

comment:1 Changed 9 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.4
Priority: LowNormal

comment:2 Changed 9 years ago by Garry Yao

Resolution: invalid
Status: newclosed

Have to say it's not really a bug, 'link' plugin should be considered as been enhanced by 'htmldataprocessor' instead of relying on it - it will continue to function, in case the other exist, it provide a better experience:

var dataProcessor = editor.dataProcessor,
	dataFilter = dataProcessor && dataProcessor.dataFilter;

if ( dataFilter )

That's the way we understand our plugin dependencies.

comment:3 Changed 9 years ago by Scott González

In 3.0.1, link did depend on htmldataprocessor to function properly. This seems to have been fixed (tested against 3.2.1).

In 3.0.1, if you included the link plugin, but not the htmldataprocessor plugin you would get elements like this:

<a _cke_saved_href="http://example.com" href="javascript:void(0)/*274*/">test</a>

Instead of:

<a href="http://example.com">test</a>

The resolution should be changed from invalid to fixed.

comment:4 Changed 9 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.4
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy