IE Fails to apply type="text" attribute to Text Fields

[Jerry Martinez]

Descriptive summary: When creating a Text Field element of type="text" Internet Explorer does not apply the 'type' attribute to the input tag. Because of this, the Context Menu for the same Text Field element will NOT display if accessed using FireFox.

This bug was realized since our application saves HTML into a database where users can modify the markup using CKEDITOR. Some of our users use Internet Explorer while others use FireFox.

Steps to reproduce: Using Internet Explorer:

1. Create a sample Text Field element.
2. Toggle 'Source' mode and copy the HTML which may look like this:

   <p>
   	<input maxlength="5" name="testName" size="5" value="testValue" /></p>
   

Using FireFox:

1. Toggle 'Source' mode and paste the above HTML.
2. Toggle off 'Source' mode back to Editor mode.
3. Right click on the created Text Field and you will notice that the option "Text Field Properties" is not present.

Verified With: CKEDITOR 3.2.1 using IE7 & FF 3.5.9 CKEDITOR 3.2.2 SVN using IE7 & FF 3.5.9

[Jerry Martinez]

This is a patch, not a solution to the problem. The solution would be to ensure that the 'type' attribute gets inserted in IE.

This patch allows the context menu to work properly for input elements missing a 'type' attribute.

First time contributing. I am not sure I followed the correct steps. I basically edited the ckeditor/_soource/plugins/forms/plugin.js file from the nightly build.

[Alfonso Martínez de Lizarrondo]

If you close a ticket, then no one will look at it. Please, read ​the Ticket life cycle

[Alfonso Martínez de Lizarrondo]

Proposed patch

[Alfonso Martínez de Lizarrondo]

The patch fixes the problem, but while testing it be aware of #6646 because the context menu won't work when the content is reloaded.

[Alfonso Martínez de Lizarrondo]

Note: IE8 in standards mode works correctly by default, the lack of type="text" is only present in compatibility mode or old versions.

[Garry Yao]

Let's have #6646 fixed first.

[Garry Yao]

Why we're still keeping the last chunk of the patch (being text type as the default)?

[Alfonso Martínez de Lizarrondo]

Yes, we cold skip those two lines, but on the other hand it will avoid changes to the source if the content is first created with a compliant browser that generates the type="text" and then edited with IE that will remove it.

[Alfonso Martínez de Lizarrondo]

Fixed with [6296]