Opened 7 years ago

Closed 7 years ago

#6646 closed Bug (fixed)

text inputs and areas lack context menu if they are present in the initial content

Reported by: Alfonso Martínez de Lizarrondo Owned by: Sa'ar Zac Elias
Priority: Normal Milestone: CKEditor 3.5.1
Component: General Version: 3.4
Keywords: Cc:

Description

Follow up from #6046

That ticket fixed the context menu for those elements when they are inserted, but if they are present in the original content, then the isReadOnly() check returns the element and so they aren't editable.

Reproduction steps:

  1. Insert a text input, check that the context menu for editing it appears.
  2. Switch to source and back to design.
  3. The context menu entry is missing.

(be careful if checking with IE due to #5522)

Attachments (2)

6646.patch (2.6 KB) - added by Garry Yao 7 years ago.
6646_2.patch (2.6 KB) - added by Sa'ar Zac Elias 7 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 7 years ago by Sa'ar Zac Elias

Status: newconfirmed

Changed 7 years ago by Garry Yao

Attachment: 6646.patch added

comment:2 Changed 7 years ago by Garry Yao

Milestone: CKEditor 3.5.1
Owner: set to Garry Yao
Status: confirmedreview

One thing need to be reviewed is whether it works with [some hacks http://dev.fckeditor.net/browser/CKEditor/trunk/_source/plugins/forms/dialogs/textfield.js#L177 ] we introduced in IE for inputs.

comment:3 Changed 7 years ago by Tobiasz Cudnik

Status: reviewreview_failed

The Value field is empty when trying to edit the control.

Changed 7 years ago by Sa'ar Zac Elias

Attachment: 6646_2.patch added

comment:4 Changed 7 years ago by Sa'ar Zac Elias

Owner: changed from Garry Yao to Sa'ar Zac Elias
Status: review_failedreview

comment:5 Changed 7 years ago by Garry Yao

Status: reviewreview_passed

comment:6 in reply to:  3 Changed 7 years ago by Garry Yao

Replying to tobiasz.cudnik:

The Value field is empty when trying to edit the control.

Missing value attribute is an known IE7 bug and we've already had a ticket for it.

comment:7 Changed 7 years ago by Sa'ar Zac Elias

Resolution: fixed
Status: review_passedclosed

Fixed with [6289].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy