Opened 8 years ago

Last modified 7 years ago

#5614 review Bug

Selection incorrect after Undo

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone:
Component: Core : Undo & Redo Version: 3.0
Keywords: Cc: satya_minnekanti@…

Description

Environment

IE, enterMode = CKEDITOR.ENTER_BR;

Reproducing Procedures

  1. Open any of the sample page and click on 'New Page' to clear all contents;
  2. Click on 'Insert Horizontal Line' 3 times to insert 3 <hr>;
  3. Undo once to revert one <hr>
  4. Strart typing some text
    • Actual Result: The inserted text appears after the first <hr>;
    • Expected Result: The inserted text appears after the second <hr>;

Attachments (2)

5416_POD.html (1.2 KB) - added by Garry Yao 8 years ago.
Proof of Diagnosis for the innerHTML problem
5614.patch (5.2 KB) - added by Garry Yao 8 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 8 years ago by Garry Yao

The problem is that IE, when retrieving innerHTML( via editor.getSnapshot()), insist on having line-break after <hr>, the result is that our bookmarks, which are created based on the original DOM structure (have no line-break between nodes), result in wrong position when applied.

Changed 8 years ago by Garry Yao

Attachment: 5416_POD.html added

Proof of Diagnosis for the innerHTML problem

Changed 8 years ago by Garry Yao

Attachment: 5614.patch added

comment:2 Changed 8 years ago by Garry Yao

Keywords: Review? added
Milestone: CKEditor 3.3
Owner: set to Garry Yao
Status: newassigned

Proposing of ignoring non-visible empty spaces on creating/selecting bookmark2.

comment:3 Changed 8 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.3CKEditor 3.4

comment:4 Changed 8 years ago by Sa'ar Zac Elias

Cc: saarelias@… added

comment:5 Changed 7 years ago by Garry Yao

#5675 has been marked as a DUP.

comment:6 Changed 7 years ago by Satya Minnekanti

Cc: satya_minnekanti@… added

comment:7 Changed 7 years ago by Frederico Caldeira Knabben

Keywords: Confirmed IE? removed
Milestone: CKEditor 3.4

comment:8 Changed 7 years ago by Sa'ar Zac Elias

Cc: saarelias@… removed
Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy