Opened 10 years ago

Last modified 9 years ago

#5700 confirmed Bug

SCAYT doesn't work with 'replace' command

Reported by: Garry Yao Owned by:
Priority: Normal Milestone:
Component: UI : Spell Checker Version: 3.4.2
Keywords: HasPatch, Review? Cc: WebSpellChecker.net

Description (last modified by Frederico Caldeira Knabben)

  1. Load the following content in editor;
    <p>
    	wrongspell</p>
    
    • Expected Result: The word is red-marked in wysiwyg mode.
  2. Open 'Replace' dialog and replace the word with "right spell", then close the dialog.
    • Expected Result: The red underline is removed.
    • Actual Result: The red underline is still in place.

Attachments (2)

5700.patch (3.0 KB) - added by WebSpellChecker.net 9 years ago.
5700.2.patch (4.2 KB) - added by WebSpellChecker.net 9 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 9 years ago by Frederico Caldeira Knabben

Description: modified (diff)

comment:2 Changed 9 years ago by WebSpellChecker.net

Keywords: Confirmed added

comment:3 Changed 9 years ago by WebSpellChecker.net

Keywords: HasPatch Review? added; Confirmed removed
Version: 3.4.1

Here we propose patch which refreshes SCAYT markup after any dialog close (including Find&Replace dialog). While dialog is open, SCAYT pauses its work.

Please, review.

Changed 9 years ago by WebSpellChecker.net

Attachment: 5700.patch added

comment:4 Changed 9 years ago by Garry Yao

Keywords: Review? removed

We could accept this fix, while one step further, is it possible to make SCAYT refreshes once DOM changes are introduced (just like normal editing)?

comment:5 Changed 9 years ago by Garry Yao

And, the 'insertElement/insertHtml' refresh must be still kept, they're also used elsewhere beside dialogs.

comment:6 Changed 9 years ago by WebSpellChecker.net

Keywords: Review? added
Version: 3.4.13.4.2

This problem was fixed in new SCAYT core and will work after updating SCAYT to version 2.6.0 with this task: #6769

comment:7 Changed 9 years ago by WebSpellChecker.net

Now SCAYT markup hides, when user opens a dialog window.

We have also updated the patch, refresh on 'insertElement/insertHtml' events is restored. Please, review.

Changed 9 years ago by WebSpellChecker.net

Attachment: 5700.2.patch added
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy