Opened 7 years ago

Closed 7 years ago

#5772 closed Bug (fixed)

[IE] Not all list-style-type values are supported by IE

Reported by: Joe Kavanagh Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.3.1
Component: Core : Lists Version: SVN (CKEditor) - OLD
Keywords: IBM Confirmed Review+ Cc: Damian Satya Minnekanti

Description

The list style dialog provides options for armenian, georgian, lower-greek and decimal-leading-zero. These list-style-type values are not supported by any version of IE.

IE does not support the values armenian, decimal-leading-zero, georgian, inherit, lower-greek, lower-latin or upper-latin.

Attachments (5)

5772.patch (534 bytes) - added by Garry Yao 7 years ago.
api_dialog.html (2.9 KB) - added by Garry Yao 7 years ago.
ScriptError_5567.png (15.1 KB) - added by Damian 7 years ago.
5772_2.patch (2.0 KB) - added by Garry Yao 7 years ago.
5772_3.patch (2.0 KB) - added by Garry Yao 7 years ago.

Download all attachments as: .zip

Change History (19)

comment:1 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.xCKEditor 3.4

We're using the W3C allowed CSS values for the list-style property. It's in fact an IE fault to not support them, and those should silently fall into a roman numbered list in that browser, while rendering properly in others.

If you want to remove those items, you'll need to customize the dialog for your needs. But, the fact is that the dialog definition doesn't have an ID for the first dialog page, and so it's not possible to work on it through the API. I'm leaving this ticket opened so it can be fixed.

Changed 7 years ago by Garry Yao

Attachment: 5772.patch added

comment:2 Changed 7 years ago by Garry Yao

Keywords: Confirmed Review? added
Owner: set to Garry Yao
Status: newassigned

comment:3 Changed 7 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review+ added; Review? removed

comment:4 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.4CKEditor 3.3.1

comment:5 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [5561].

comment:6 Changed 7 years ago by Joe Kavanagh

Resolution: fixed
Status: closedreopened

The associated patch does not address the reported issue.

Changed 7 years ago by Garry Yao

Attachment: api_dialog.html added

comment:7 in reply to:  6 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: reopenedclosed

Replying to JoeK:

The associated patch does not address the reported issue.

We're not going to remove those options as they are supported by IE8 and should be degradable in lower IE versions, I've included a sample that demonstrate the customization of the select options if you insist on removing them.

Changed 7 years ago by Damian

Attachment: ScriptError_5567.png added

comment:8 Changed 7 years ago by Damian

Resolution: fixed
Status: closedreopened

The real problem here is that in IE, if an unsupported number type is selected a script error is thrown. CKEditor should not allow a script error like this, especially if this is a known issue.

comment:9 Changed 7 years ago by Garry Yao

Keywords: Review+ removed
Status: reopenednew

Changed 7 years ago by Garry Yao

Attachment: 5772_2.patch added

comment:10 Changed 7 years ago by Garry Yao

Keywords: Review? added
Status: newassigned

comment:11 Changed 7 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

The browser check must also consider future IE versions, so the check should be:

if ( CKEDITOR.env.ie && CKEDITOR.env.version > 7 )

Other than that, the negation way the condition has been checked is confusing.

Changed 7 years ago by Garry Yao

Attachment: 5772_3.patch added

comment:12 Changed 7 years ago by Garry Yao

Keywords: Review? added; Review- removed

comment:13 Changed 7 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:14 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [5579].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy