SCAYT: Memory leak in IE

[Wiktor Walc]

In IE6 there is a 8MB memory leak every time an instance of CKEditor is created.

Confirmed using Process Explorer, after creating & destroying CKEditor 10 times (using AJAX sample), memory usage (private bytes) jumped from 9MB to 90MB (tested on IE6.0.3790.1830 @ Win2003/SP1, also reported by user using IE6 6.0.2900.2180).

I have attached a dump from IE Sieve.

[Wiktor Walc]

Disabling scayt with:

config.scayt_autoStartup = false;

reduces the memory leak to 1.8MB in IE6.

The memory leak in IE8 with scayt enabled is around 10MB.

[WebSpellChecker.net]

WebSpellChecker.net team made refactoring of SCAYT plug-in. Memory leaks related to plug-in code were fixed.
WebSpellChecker.net team continues working on memory leaks issues in SCAYT core.

[Garry Yao]

The patch is not clear of what changes has fixes the leak that makes the review hard, please dont include unrelated changes into the review.

By checking only the code, I can still confirm at least the following reference chains that would leak:

1. CKEDITOR.plugins.undo.Image.prototype.equals -> editor
2. oParams.onLoad -> editor.document.getWindow().$.frameElement

[Frederico Caldeira Knabben]

This is refactoring, Garry, so I think we'll need to have a full review here and accept the patch as valid.

As always, someone on the core team should take the ownership of the ticket, eventually providing a cleaner patch for final review (only if required).

[Frederico Caldeira Knabben]

Well... only if SpellChecker.net is really able to provide a new patch that fixes the memory leak only. Than, that's a different case.

[WebSpellChecker.net]

We are in progress review whether we're able to prepare patch which fixes memory leaks only.