Opened 7 years ago

Closed 7 years ago

#6133 closed Bug (fixed)

Styled paragraphs result on buggy list creation

Reported by: Frederico Caldeira Knabben Owned by: Martin
Priority: Normal Milestone: CKEditor 3.4.2
Component: Core : Lists Version: 3.4.1
Keywords: Firefox Cc: satya_minnekanti@…

Description

  1. Clear the editor.
  2. Type two paragraphs.
  3. CTRL+A to select all.
  4. Hit the "Bold" button.
  5. Hit the "Unordered List" button.

Note that there is a line space between the items. This is what we have on source:

<ul>
	<li>
		<strong>Para 1</strong><br />
		&nbsp;</li>
	<li>
		<strong>Para 2</strong><br />
		&nbsp;</li>
</ul>

We should not have the "<br />&nbsp;" thing on each item.

This doesn't happen if the paragraphs are not styled.

Attachments (2)

#6133.patch (484 bytes) - added by Martin 7 years ago.
Patch
6133_2.patch (432 bytes) - added by Martin 7 years ago.
Patch

Download all attachments as: .zip

Change History (12)

comment:1 Changed 7 years ago by Sa'ar Zac Elias

Keywords: Firefox added
Status: newconfirmed

Only happens on FF.

comment:2 Changed 7 years ago by Martin

Owner: set to Martin
Status: confirmedassigned

Changed 7 years ago by Martin

Attachment: #6133.patch added

Patch

comment:3 Changed 7 years ago by Martin

Status: assignedreview

comment:4 Changed 7 years ago by Sa'ar Zac Elias

#6267 is a DUP.

comment:5 Changed 7 years ago by Satya Minnekanti

Cc: satya_minnekanti@… added

comment:6 Changed 7 years ago by Tobiasz Cudnik

Status: reviewreview_failed

I'm not sure we should remove fix from #3409. have you checked that it's not more reproducible ?

Changed 7 years ago by Martin

Attachment: 6133_2.patch added

Patch

comment:7 Changed 7 years ago by Martin

Status: review_failedreview

6133_2 remove lines add in 3409 because #2886 fix all issue consists with "line height" by add '&nbsp' sign. So at this moment #3409 is completly unnecessary

comment:8 Changed 7 years ago by Tobiasz Cudnik

Status: reviewreview_passed

comment:9 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.5CKEditor 3.4.2

comment:10 Changed 7 years ago by Martin

Resolution: fixed
Status: review_passedclosed

fixed with revision [5922]

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy