enterMode = br produces error in Firefox 3.6.8

[libek]

This is a brand-new problem; I just downloaded a clean install of 3.3.2. (No, I haven't tried it in the beta.)

[ I understand that this setting is unrecommended, but I really NEED it for the project I'm working on; I can't force the whole project to use <p>'s, so there's just no point in generating them. ]

The error being generated in 3.3.2 only shows up when you set it to enterMode = CKEDITOR.ENTER_BR (and this is in the config.js file, FYI). No errors happen when it's set to ENTER_P or ENTER_DIV.

The error Firefox's Error Console gives me is:

Error: C.getFirst().hasAttribute is not a function Source File: [...]ckeditor/ckeditor.js Line: 86

[libek]

Although, for the record, I would GLADLY switch to <p>'s if anyone could tell me how to make a custom tag a block element.

CKEDITOR.dtd.$empty.lj = 1; CKEDITOR.dtd.$empty.user = 1;

<--this worked just fine on the custom tags <lj> and <user>, making it so that the fakeobjects plugin was able to handle them as an empty element.

CKEDITOR.dtd.$block.cut = 1;

<--didn't work at all. It shows up when I force an iteration of the block elements, but it still can't contain <p>'s, and it needs to be able to contain <p>'s AND <table>'s AND <div>'s.

...Just toooossing that out there, in case anyone has a really quick easy suggestion for me, because I'd LOVE for <p>'s to be a viable option.

[Tobiasz Cudnik]

Error happens when there is only text node in the editor, which doesn't have getAttribute method.

[Sa'ar Zac Elias]

I'm not able to figure out how to reproduce the problem. Can any of you attach some more exact steps to reproduce the bug?

[Sa'ar Zac Elias]

Both Tobiasz and I can't reproduce this issue anymore.

[Niko Viitala]

There is again the same problem in the latest nightly build:

D.getFirst().hasAttribute is not a function

If I comment out the enter mode variable the problem disappears.

[Sa'ar Zac Elias]

Can you provide exact steps how to reproduce the bug? A sample page maybe?

[Tobiasz Cudnik]

This bug happens when Firebug is enabled, enterMode=BR and you follow those steps:

• Type something in the editor
• Select all (CTRL+A)
• Start typing (no backspace)

It happens always for me and it's annoying during development.

[Garry Yao]

This will probably not in 3.4.2, are you sure it's not a DUP of #5253?

[Tobiasz Cudnik]

It's not a DUP of #5253, as i'm using Firebug 1.7X.0a3. You aren't able to reproduce it?

[martin_42]

I fixed the issue by changing:

ckeditor/_source/plugins/wysiwygarea/plugin.js

<    if ( !bodyChildsNum || ( bodyChildsNum == 1&& body.getFirst().hasAttribute( '_moz_editor_bogus_node' ) ) )
---
>    if ( !bodyChildsNum || !body.getFirst() || ( bodyChildsNum == 1 && body.getFirst().hasAttribute( '_moz_editor_bogus_node' ) ) )

[Garry Yao]

Any error thrown in "selectionchange" event should be concealed by try...catch and thus can be only reproduced by enable error tracking of Firebug.

[dchill42]

This bug continues to be an issue in 3.5.2. When enterMode is set to CKEDITOR.ENTER_BR, and the editor loads with content, the first node of which is text (as opposed to a tag like <p>), body.getFirst().hasAttribute() is undefined. This is because getFirst() returns the text node, which does not have a hasAttribute() method. The offending code is in the activateEditing() function of the wysiwygarea plugin.

The previously posted patch also has a logic flaw, at least in newer versions. It runs the code block, which is ostensibly meant to remove the bogus node inserted by firebug. In the scenario described above, this results in the removal of the first text node from the editor. Instead, the test should be

(bodyChildsNum == 1 && body.getFirst().hasAttribute && body.getFirst().hasAttribute('_moz_editor_bogus_node'))

such that the node isn't tested for the obviously absent attribute on a text node, nor is the text node inadvertently removed.

I will attach a new patch with this fix in the hope that it will get incorporated into the next release.

[dchill42]

Patch file for plugins/wysiwygarea/plugin.js v > 3.5

[Jakub Ś]

I can no longer reproduce this issue in latest Firefox and CKEditor (4.4.7 and 4.5 beta at the time of writing).