Opened 7 years ago

Closed 4 years ago

#6153 closed Bug (fixed)

Chrome: tab focus is wrong.

Reported by: Moshe Owned by:
Priority: Normal Milestone:
Component: General Version: 3.3
Keywords: WebKit Cc:

Description

I am using the last version of CKEditor (also checked nightly build). When using Chrome (last), user pressed "tab" from text input into CKEditor, and the whole gray frame became "focused" style. I tried to press on keyboard but no response. using mouse worked.

Attachments (3)

6153.patch (1.2 KB) - added by Tobiasz Cudnik 7 years ago.
6153_2.patch (1.2 KB) - added by Tobiasz Cudnik 7 years ago.
6153.html (3.0 KB) - added by Sa'ar Zac Elias 7 years ago.

Download all attachments as: .zip

Change History (33)

comment:1 Changed 7 years ago by Sa'ar Zac Elias

Keywords: Webkit added
Milestone: CKEditor 3.4.1
Status: newconfirmed
Version: 3.4.1 (SVN - trunk)3.3

Supposed to be fixed by #6154.

comment:2 Changed 7 years ago by Tobiasz Cudnik

Owner: set to Tobiasz Cudnik
Status: confirmedassigned

#6154 is related strictly to Opera and no other browser should be affected by it or the reason #6154 exists (which is #6025).

comment:3 Changed 7 years ago by Tobiasz Cudnik

Owner: Tobiasz Cudnik deleted
Status: assignednew

This issue doesn't seem to be fixable, we have to find some workaround.

comment:4 Changed 7 years ago by Tobiasz Cudnik

Owner: set to Tobiasz Cudnik
Status: newassigned

Fixable by 6192.patch from #6192.

Changed 7 years ago by Tobiasz Cudnik

Attachment: 6153.patch added

comment:5 Changed 7 years ago by Tobiasz Cudnik

Status: assignedreview

This is fixed version of 6192.patch dedicated for TC of this ticket.

comment:6 Changed 7 years ago by Tobiasz Cudnik

Status: reviewassigned

This patch is accident duplicate of 6178.patch, please go to #6178.

Changed 7 years ago by Tobiasz Cudnik

Attachment: 6153_2.patch added

comment:7 Changed 7 years ago by Tobiasz Cudnik

Status: assignedreview

Changed 7 years ago by Sa'ar Zac Elias

Attachment: 6153.html added

comment:8 Changed 7 years ago by Sa'ar Zac Elias

Status: reviewreview_failed

The patch didn't resolve the issue for me. I'm attaching the TC I'm using.

comment:9 Changed 7 years ago by Tobiasz Cudnik

Status: review_failedreview

It turned out to be a cache related issue.

comment:10 Changed 7 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

Ugh.. Chrome's cache :/
Works great, sorry about that.

comment:11 Changed 7 years ago by Tobiasz Cudnik

Resolution: fixed
Status: review_passedclosed

Fixed with [5899].

comment:12 Changed 7 years ago by Tobiasz Cudnik

Commited into correct branch with [5907].

comment:13 Changed 7 years ago by Krzysztof Studnik

On Safari 5/Mac tab switching on attached html with empty text box and two editors works wrong:

  • focus set on textbox, hit tab
  • focus set on first editor, blinking cursor, no text entering is possible
  • hit tab
  • focus set on second editor, blinking cursor, no text entering is possible
  • hit tab, so the focus is back to the textbox
  • hit tab - focus is set on editor, entering is not possible
  • hit tab second time - now it is possible to enter text into editor
  • second editor - same thing

comment:14 Changed 7 years ago by Tobiasz Cudnik

Resolution: fixed
Status: closedreopened

Confirming, reduced TC:

  1. Open a sample with the editor.
  2. Hit Tab key to get into the editing area.
  3. Try to type some chars.

comment:15 Changed 7 years ago by Tobiasz Cudnik

Owner: Tobiasz Cudnik deleted
Status: reopenednew

comment:16 Changed 7 years ago by Tobiasz Cudnik

Status: newconfirmed

Seems someone had reverted [5907].

comment:17 Changed 7 years ago by Tobiasz Cudnik

Owner: set to Tobiasz Cudnik
Status: confirmedassigned

comment:18 Changed 7 years ago by Wiktor Walc

Milestone: CKEditor 3.4.2CKEditor 3.4.3

Postponing to 3.4.3 as fixing it asap could introduce more unknown issues.

comment:19 Changed 7 years ago by Garry Yao

I still dunno why this ticket is reopened.

comment:20 Changed 7 years ago by Garry Yao

Status: assignedpending

[5907] is not partially reverted, precisely the part that not related to the ticket. Can anyone confirm this a Mac OS issue? WFM in both Chrome/Safari on Windows.

comment:21 Changed 7 years ago by Tobiasz Cudnik

Status: pendingconfirmed

We had already confirmed (1, 2) that this is an issue on Macosx, using Safari5.

However, it's not related to partially reverted [5907].

comment:22 Changed 7 years ago by Frederico Caldeira Knabben

Keywords: WebKit added; Webkit removed
Milestone: CKEditor 3.4.3CKEditor 3.5.1

Is it related to a WebKit bug? Do you have a ticket at their side for it?

comment:23 Changed 7 years ago by Tobiasz Cudnik

Since #6192 i can't create a reduced TC for this issue and i think it's related to our complex focus logic. Thus, we don't have a ticket for this issue, although we can point them to some of our samples, but i don't know if it's appropriate.

comment:24 Changed 7 years ago by Garry Yao

#6296 is marked as a DUP.

comment:25 Changed 7 years ago by Wiktor Walc

Milestone: CKEditor 3.5.1CKEditor 3.5.2

comment:26 Changed 6 years ago by Frederico Caldeira Knabben

I did some research, by testing the replacebycode sample.

"TAB and type" was used to work well with the 3.2.2.

It stopped working properly with the 3.3. "Typing" was working only on the first editor.

The culprit for the issue, at that release is [5509], a changeset with no ticket or review :/

Then with the 3.3.2 things got worst... no "typing" at all.

It never worked well since then, and the behavior changed a bit on the following releases.

comment:27 Changed 6 years ago by Frederico Caldeira Knabben

Owner: Tobiasz Cudnik deleted
Status: confirmednew

comment:28 Changed 6 years ago by Frederico Caldeira Knabben

Status: newconfirmed

comment:29 Changed 6 years ago by Wiktor Walc

Milestone: CKEditor 3.5.3

comment:30 Changed 4 years ago by Jakub Ś

Resolution: fixed
Status: confirmedclosed

Problem is no longer reproducible in CKE 4.2.2.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy