autogrow setTimeout causes problems

[Dinu]

The autogrow timeout to resize the contents causes a couple of problems: 1) Scrollbars appearing (I don't know if this is avoidable?) 2) JS errors when destroying editor (function runs after window is destroyed) (trivial fix attached)

[Dinu]

Patch to test for editor.window before trying to resize

[Wiktor Walc]

Ad 1) I assume you're talking about scrollbars that appear for less than a second straight before CKEditor resizes itself?

Ad 2) Confirmed

editor.window is null
ckeditor/_source/plugins/autogrow/plugin.js
Line 13

[Dinu]

1) Yes, I'm not sure it's avoidable. However, I am currently using the plugin w/o the 100ms timeout; it's faster and I see no glitch, is it an all-browsers must?

[Sa'ar Zac Elias]

Considering insertHtml wasn't even listed, and I don't see a glitch with any of the events, we don't need the timeout.

[Garry Yao]

The timeout must be kept, as we have no guarantee on when actual content will be inserted on those events, the right way to deal with the scrollbar flicking is to persist overflow:hidden to doc.

[Garry Yao]

The proposed solution looks quite complicated, I dont think the flicking scrollbar issue desires to fix in this way, so right now let's just have the JS errors addressed.

[Sa'ar Zac Elias]

Fixed with [6428].