BIDI: Language direction should be applied to individual list items and not the entire block

[James]

Steps to reproduce the defect:

1. Open the Ajax sample.
2. Enter the following content into the editor:

<p>This is a sample paragraph.</p>
<ul>
	<li>List item 1</li>
	<li>List item 2</li>
	<li>List item 3</li>
	<li>List item 4</li>
</ul>

3. Select the first paragraph and the first 2 list items.
4. Click on the RTL icon.

Expected: RTL language direction is applied to the first paragraph & the first 2 items in the list.

Actual: RTL language direction is applied to the first paragraph & the whole list.

[Garry Yao]

DUP of #6235.

[Damian]

This is not actually a duplicate of #6235, which only works if the selection is confined to within the list.

The test case for this ticket is selecting a paragraph outside the list and some items from within the list.

Reproduced on the nightly build, the effect of making a selection like this causes the whole list to become RTL instead of just the selected paragraph and list items.

[Garry Yao]

@damo, you're right, let's keep this in 3.4.2 still.

[Sa'ar Zac Elias]

The patch failes for nested tabels:

<ol>
	<li>
		[aa]
		<ol>
			<li>
				bb</li>
			<li>
				[cc]</li>
		</ol>
	</li>
	<li>
		dd</li>
	<li>
		ee</li>
</ol>

[Garry Yao]

It's related to the wrong way of iterating ranges, actually wouldn't taken into count at this ticket, but well, considering of multiple ranges is completely broken because of it, it's in!

[Sa'ar Zac Elias]

Selecting the first and last items converts the whole list:

<ol>
	<li>
		[a]</li>
	<li>
		b</li>
	<li>
		[c]</li>
</ol>

Also, it seems that the processedElements variable is never in use, you can remove it from the code.

[Tobiasz Cudnik]

Following TC fails using 6485_3.patch:

<ol>
	<li>
		[aa
		<ol>
			<li>
				bb]</li>
			<li>
				cc</li>
		</ol>
	</li>
	<li>
		dd</li>
	<li>
		ee</li>
</ol>

I don't think we should bother about multi range selection at this point.

[Tobiasz Cudnik]

My previous comment was incorrect, the LI with "cc" content is RTL by the document structure, so everything is fine here.

[Garry Yao]

Well, things are become a lot complicated to support Firefox's multiple ranges, I'm proposing a patch here that should handles general situations, if the review of this fails, we'll be probably accepting the fail of last TC and open ticket to fix it later.

[Garry Yao]

The previous patch doesn't pass an edge case which Tobias pointed out, in the following TC, the entire table should hold the style instead of on the table row.

<table>
 <tbody>
  <tr>
   <td>
    ^TD</td>
  </tr>
 </tbody>
</table>

[Garry Yao]

New patch instead is always greedy on grabbing further ancestor.

[Garry Yao]

Fixed with [6003].

[Sa'ar Zac Elias]

Reverted [6003] with [6007] as it brings some pretty bad regressions (#6536, #6530), block handling is pretty badly damaged.

[Garry Yao]

It's quite a pity that the changeset is reverted because of one bookmark node. :(

[Garry Yao]

Fixed with [6031].