Opened 7 years ago

Closed 7 years ago

#6569 closed Bug (fixed)

Indentation doesn't honor text direction in list

Reported by: Garry Yao Owned by: Sa'ar Zac Elias
Priority: Normal Milestone: CKEditor 3.4.3
Component: Core : Lists Version: 3.4
Keywords: Cc:

Description

  1. Load the following content and selection:
    <ol>
    	<li dir="rtl" style="border: 1px solid">
    			^right to left
    	</li>
    </ol>
    
  2. Click on "Increase Indent";
    • Actual Result: Left-margin style is applied;
    • Expected Result: Right-margin should be applied.

Attachments (1)

6569.patch (2.8 KB) - added by Sa'ar Zac Elias 7 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 7 years ago by Tobiasz Cudnik

Owner: set to Tobiasz Cudnik
Status: newassigned

comment:2 Changed 7 years ago by Tobiasz Cudnik

Status: assignedpending

This not a regression since 3.4.1, actually it's a result of [5307] from #3893, which introduces the design decision described as "Indent the entire list if cursor is inside the first list item".

Any propositions how to match those two ?

comment:3 Changed 7 years ago by Garry Yao

Any propositions how to match those two ?

Yes, it should be ok after #6485.

Changed 7 years ago by Sa'ar Zac Elias

Attachment: 6569.patch added

comment:4 Changed 7 years ago by Sa'ar Zac Elias

Milestone: CKEditor 3.4.2CKEditor 3.4.3
Owner: changed from Tobiasz Cudnik to Sa'ar Zac Elias
Status: pendingreview

The way I see it, we should respect the direction of the first item only if it's the only item there.
Not a regression, so I'm targeting it to the next release.

comment:5 Changed 7 years ago by Garry Yao

Status: reviewreview_failed

The idea is ok, while for me we should only touch "getIndentCssProperty" function now.

comment:6 Changed 7 years ago by Sa'ar Zac Elias

Status: review_failedreview

The approach of my patch saves us some lines and redundant traveling of the DOM.

comment:7 Changed 7 years ago by Garry Yao

Status: reviewreview_passed

comment:8 Changed 7 years ago by Sa'ar Zac Elias

Resolution: fixed
Status: review_passedclosed

Fixed with [6052].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy