Opened 13 years ago
Closed 13 years ago
#6569 closed Bug (fixed)
Indentation doesn't honor text direction in list
| Reported by: | Garry Yao | Owned by: | Sa'ar Zac Elias |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.4.3 |
| Component: | Core : Lists | Version: | 3.4 |
| Keywords: | Cc: |
Description
- Load the following content and selection:
<ol> <li dir="rtl" style="border: 1px solid"> ^right to left </li> </ol>
- Click on "Increase Indent";
- Actual Result: Left-margin style is applied;
- Expected Result: Right-margin should be applied.
Attachments (1)
Change History (9)
comment:1 Changed 13 years ago by
| Owner: | set to Tobiasz Cudnik |
|---|---|
| Status: | new → assigned |
comment:2 Changed 13 years ago by
| Status: | assigned → pending |
|---|
comment:3 Changed 13 years ago by
Any propositions how to match those two ?
Yes, it should be ok after #6485.
Changed 13 years ago by
| Attachment: | 6569.patch added |
|---|
comment:4 Changed 13 years ago by
| Milestone: | CKEditor 3.4.2 → CKEditor 3.4.3 |
|---|---|
| Owner: | changed from Tobiasz Cudnik to Sa'ar Zac Elias |
| Status: | pending → review |
The way I see it, we should respect the direction of the first item only if it's the only item there.
Not a regression, so I'm targeting it to the next release.
comment:5 Changed 13 years ago by
| Status: | review → review_failed |
|---|
The idea is ok, while for me we should only touch "getIndentCssProperty" function now.
comment:6 Changed 13 years ago by
| Status: | review_failed → review |
|---|
The approach of my patch saves us some lines and redundant traveling of the DOM.
comment:7 Changed 13 years ago by
| Status: | review → review_passed |
|---|
comment:8 Changed 13 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with [6052].
Note: See
TracTickets for help on using
tickets.
This not a regression since 3.4.1, actually it's a result of [5307] from #3893, which introduces the design decision described as "Indent the entire list if cursor is inside the first list item".
Any propositions how to match those two ?