Opened 7 years ago

Closed 7 years ago

#6568 closed Bug (fixed)

Bug in table insert row

Reported by: Alex Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.5.1
Component: Core : Tables Version: 3.0
Keywords: IBM Cc: satya_minnekanti@…

Description

Hello!

I've found the bug in release 3.4.1 and in earlier reliases: any attempt to add a row to a table with a cell, splitted horizontally, ruins the table completely. This is a simple example. Create table:

<table border="1" cellpadding="1" cellspacing="1" style="width: 500px">

<tbody>

<tr>

<td rowspan="2">

&nbsp;</td>

<td>

&nbsp;</td>

</tr> <tr>

<td>

&nbsp;</td>

</tr>

</tbody>

</table>

The table has one row and two columns. The right cell is divided horizontally. If you try to add row to the table (before or after existing row - does not matter) - the table corrupts.

That is the story :(

Attachments (3)

6568.patch (4.4 KB) - added by Garry Yao 7 years ago.
6568_2.patch (11.6 KB) - added by Garry Yao 7 years ago.
6568_3.patch (12.2 KB) - added by Garry Yao 7 years ago.

Download all attachments as: .zip

Change History (16)

comment:1 Changed 7 years ago by Garry Yao

Keywords: table insert split removed
Milestone: CKEditor 3.4.3
Status: newconfirmed
Version: 3.4.13.0

Changed 7 years ago by Garry Yao

Attachment: 6568.patch added

comment:2 Changed 7 years ago by Garry Yao

Owner: set to Garry Yao
Status: confirmedreview

Revised 'insertRow' and 'insertCol' to handle cell spanning.

comment:3 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.4.3CKEditor 3.5.1

comment:4 Changed 7 years ago by Garry Yao

Summary: Bug in table insert lineBug in table insert row

comment:5 Changed 7 years ago by Garry Yao

Status: reviewreview_failed

delete row/column should be included also, v2 ticket #2813.

Changed 7 years ago by Garry Yao

Attachment: 6568_2.patch added

comment:6 Changed 7 years ago by Garry Yao

Status: review_failedreview

A completely rewrite of the insert/delete column/row functions that takes care of cell spanning.

comment:7 Changed 7 years ago by Tobiasz Cudnik

Status: reviewreview_passed

comment:8 Changed 7 years ago by Garry Yao

Status: review_passedreview_failed

"insert column after" with the following content and cursor position produces wrong result:

<table border="1" cellpadding="1" cellspacing="1" style="width: 500px;">
	<tbody>
		<tr>
			<td colspan="2" rowspan="1">
				1</td>
			<td colspan="1" rowspan="2">
				2^</td>
		</tr>
		<tr>
			<td>
				3</td>
			<td>
				4</td>
		</tr>
		<tr>
			<td>
				5</td>
			<td>
				6</td>
			<td>
				7</td>
		</tr>
	</tbody>
</table>

comment:9 Changed 7 years ago by Wiktor Walc

Component: GeneralCore : Tables

comment:10 Changed 7 years ago by Satya Minnekanti

Cc: satya_minnekanti@… added
Keywords: IBM added

Changed 7 years ago by Garry Yao

Attachment: 6568_3.patch added

comment:11 Changed 7 years ago by Garry Yao

Status: review_failedreview

comment:12 Changed 7 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

comment:13 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [6328].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy