Ticket #6621 (closed Bug: fixed)

Opened 3 years ago

Last modified 3 years ago

Webkit: Cannot apply a text color because of an input element

Reported by: tobiasz.cudnik Owned by: Saare
Priority: Normal Milestone: CKEditor 3.4.2
Component: General Version: 3.4.2
Keywords: Webkit Cc:

Description (last modified by tobiasz.cudnik) (diff)

In Chrome, we cannot apply a text color because of an input element.

  1. Use the following content:
    <p>
    	foo</p>
    <p>
    	<input type="radio" />bar</p>
    
    1. Select all.
    2. Set a text color.

Result: The color is applied only to the first paragraph ("foo").

This is an regression against 3.4.1.

Attachments

6621.patch (997 bytes) - added by Saare 3 years ago.
6621_2.patch (2.5 KB) - added by garry.yao 3 years ago.

Change History

comment:1 Changed 3 years ago by tobiasz.cudnik

  • Status changed from new to confirmed

Blockquote is also affected.

comment:2 Changed 3 years ago by tobiasz.cudnik

  • Description modified (diff)

comment:3 Changed 3 years ago by wwalc

  • Version set to 3.4.2 (SVN - trunk)
  • Milestone set to CKEditor 3.4.2

Regression

comment:4 Changed 3 years ago by wwalc

Caused by [5873] (#6282).

comment:5 Changed 3 years ago by fredck

I think wwalc wanted to point to [5973] instead.

comment:6 Changed 3 years ago by tobiasz.cudnik

The important fact: the select element doesn't trigger such behavior.

comment:7 Changed 3 years ago by Saare

  • Status changed from confirmed to assigned
  • Owner set to Saare

comment:8 Changed 3 years ago by garry.yao

What I'm seeing here: Webkit divides the range into two, separated by the radio, while it selection system has a bug that prevent from making a text selection that start after a radio later.

Changed 3 years ago by Saare

comment:9 Changed 3 years ago by Saare

  • Status changed from assigned to review

Reverted [5973], and made the bookmarks serializable. That resolves all 3 issues (this one, #6282, #6004).

comment:10 Changed 3 years ago by garry.yao

  • Status changed from review to review_passed

comment:11 Changed 3 years ago by Saare

  • Status changed from review_passed to closed
  • Resolution set to fixed

Fixed with [6035].

comment:12 Changed 3 years ago by garry.yao

Actually we accepted 6221.patch as an urgent fix, while a cleaner fixes has to be delivered only for this particular case, but not bringing back [5744], which introduces complexities to the codes.

Providing here a second patch to be considered later.

Changed 3 years ago by garry.yao

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy