Opened 7 years ago

Closed 4 years ago

#6795 closed Bug (fixed)

SCAYT Languages tab should contain some spacing between the radio buttons and labels

Reported by: Anna Tomanek Owned by: Anna Tomanek
Priority: Normal Milestone:
Component: UI : Spell Checker Version:
Keywords: HasPatch Cc: tech@…

Description

The "Languages" tab of the Spell Check As You Type dialog window would benefit from some spacing between the radio buttons and their labels, similar to the formatting of the "Options" tab & its checkboxes. Right now it looks a bit crammed/ ugly.

Languages tab: http://docs.cksource.com/images/b/b4/CKEditor_SCAYT_languages.png

Options tab: http://docs.cksource.com/images/b/b6/CKEditor_SCAYT_options.png

Attachments (1)

6795.patch (1.8 KB) - added by WebSpellChecker.net 6 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by WebSpellChecker.net

Cc: tech@… added
Component: UI : DialogsUI : Spell Checker

comment:2 Changed 7 years ago by Krzysztof Studnik

Status: newconfirmed

Changed 6 years ago by WebSpellChecker.net

Attachment: 6795.patch added

comment:3 Changed 6 years ago by WebSpellChecker.net

Keywords: HasPatch Review? added

Spacing between the radio buttons and labels added.

comment:4 Changed 6 years ago by Anna Tomanek

Keywords: Review? removed
Owner: set to Anna Tomanek
Status: confirmedreview

comment:5 Changed 6 years ago by Anna Tomanek

Status: reviewreview_failed

This solution does not really work as expected, since it still looks bad for Right-to-Left languages.

Besides, in CKEditor we tend to use a space placed between the checkbox/radio element and the label, like in here: https://dev.ckeditor.com/browser/CKEditor/trunk/_source/plugins/dialogui/plugin.js#L391. This helps save a couple of bytes when compared to adding multiple style declarations.

Would you be able to implement something along these lines instead? Thanks!

comment:6 Changed 4 years ago by Anna Tomanek

Resolution: fixed
Status: review_failedclosed

This is no longer a problem in current versions of WSC. Closing as fixed.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy