Opened 10 years ago

Closed 10 years ago

#6860 closed Bug (fixed)

[FF] placeholder plugin - JavaScript error

Reported by: Wiktor Walc Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.5.1
Component: UI : Dialogs Version: 3.5
Keywords: Cc:

Description (last modified by Wiktor Walc)

  1. Open _samples/placeholder.html
  2. Use the following source:
    <p>
    	Sample [[sdfsdf]]</p>
    
  3. Double click on the placeholder to open the dialog
  4. Result: the dialog didn't load the value properly and a JavaScript error occurred
element is null

http://ckeditor.local/ckeditor/3.5/_source/plugins/placeholder/dialogs/placeholder.js

Line 36

Attachments (2)

6860.patch (1.7 KB) - added by Garry Yao 10 years ago.
reduced_tc.html (435 bytes) - added by Sa'ar Zac Elias 10 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 10 years ago by Wiktor Walc

Status: newconfirmed

comment:2 Changed 10 years ago by Garry Yao

Status: confirmedpending

WFM with 4.0b8pre.

comment:3 Changed 10 years ago by Wiktor Walc

Description: modified (diff)
Milestone: CKEditor 3.5.1CKEditor 3.5.2

Simplified test case. I still can reproduce it on Firefox 4.0b8.

comment:4 Changed 10 years ago by Wiktor Walc

Keywords: FF4 removed
Milestone: CKEditor 3.5.2CKEditor 3.5.1

Confirmed also in FF 3.6.13.

comment:5 Changed 10 years ago by Garry Yao

Component: GeneralUI : Dialogs
Status: pendingconfirmed

Changed 10 years ago by Garry Yao

Attachment: 6860.patch added

comment:6 Changed 10 years ago by Garry Yao

Owner: set to Garry Yao
Status: confirmedreview
Summary: FF4: placeholder plugin - JavaScript error[FF] placeholder plugin - JavaScript error

When placeholder being the last element of the block, double click will select the previous node instead of the element itself, it's safe to just not opening the dialog in such case.

comment:7 Changed 10 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

We should file a bug to mozilla. Attaching a reduced TC.

Changed 10 years ago by Sa'ar Zac Elias

Attachment: reduced_tc.html added

comment:8 Changed 10 years ago by Garry Yao

Fixed with [6320].

comment:9 Changed 10 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Firefox bug reported.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy