Opened 5 years ago

Closed 5 years ago

#6860 closed Bug (fixed)

[FF] placeholder plugin - JavaScript error

Reported by: wwalc Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.5.1
Component: UI : Dialogs Version: 3.5
Keywords: Cc:

Description (last modified by wwalc)

  1. Open _samples/placeholder.html
  2. Use the following source:
    <p>
    	Sample [[sdfsdf]]</p>
    
  3. Double click on the placeholder to open the dialog
  4. Result: the dialog didn't load the value properly and a JavaScript error occurred
element is null

http://ckeditor.local/ckeditor/3.5/_source/plugins/placeholder/dialogs/placeholder.js

Line 36

Attachments (2)

6860.patch (1.7 KB) - added by garry.yao 5 years ago.
reduced_tc.html (435 bytes) - added by Saare 5 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 5 years ago by wwalc

  • Status changed from new to confirmed

comment:2 Changed 5 years ago by garry.yao

  • Status changed from confirmed to pending

WFM with 4.0b8pre.

comment:3 Changed 5 years ago by wwalc

  • Description modified (diff)
  • Milestone changed from CKEditor 3.5.1 to CKEditor 3.5.2

Simplified test case. I still can reproduce it on Firefox 4.0b8.

comment:4 Changed 5 years ago by wwalc

  • Keywords FF4 removed
  • Milestone changed from CKEditor 3.5.2 to CKEditor 3.5.1

Confirmed also in FF 3.6.13.

comment:5 Changed 5 years ago by garry.yao

  • Component changed from General to UI : Dialogs
  • Status changed from pending to confirmed

Changed 5 years ago by garry.yao

comment:6 Changed 5 years ago by garry.yao

  • Owner set to garry.yao
  • Status changed from confirmed to review
  • Summary changed from FF4: placeholder plugin - JavaScript error to [FF] placeholder plugin - JavaScript error

When placeholder being the last element of the block, double click will select the previous node instead of the element itself, it's safe to just not opening the dialog in such case.

comment:7 Changed 5 years ago by Saare

  • Status changed from review to review_passed

We should file a bug to mozilla. Attaching a reduced TC.

Changed 5 years ago by Saare

comment:8 Changed 5 years ago by garry.yao

Fixed with [6320].

comment:9 Changed 5 years ago by garry.yao

  • Resolution set to fixed
  • Status changed from review_passed to closed

Firefox bug reported.

Note: See TracTickets for help on using tickets.
© 2003 – 2015 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy