Opened 14 years ago
Closed 13 years ago
#6957 closed Bug (fixed)
Find is not highlighting the word in read-only blocks
Reported by: | Satya Minnekanti | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | Core : Styles | Version: | 3.5 |
Keywords: | IBM | Cc: | Damian, joek, James Cunningham |
Description
To reproduce the defect:
- copy the following code and paste it in to source
<p > first editable paragraph.</p> <p contenteditable = "false" > first non editable paragraph.</p> <p contenteditable = "false" > second non editable paragraph.</p> <p> second editable paragraph.</p>
- click on Find icon and enter the word non in find what field and click find button.
Expected Result:
non word in the first non editable paragraph should be highlighted.
Expected Result:
Find is not highlighting the non word in the first non editable but when we close the Find and Replace dialog you will see the word getting highlighted.
Attachments (2)
Change History (14)
comment:1 Changed 14 years ago by
Status: | new → confirmed |
---|---|
Version: | 3.4 → 3.5 |
comment:2 Changed 13 years ago by
Cc: | james c added; James removed |
---|
comment:3 Changed 13 years ago by
Cc: | James Cunningham added; james c removed |
---|
comment:4 Changed 13 years ago by
What do you think about adding a property called something like "appliedToReadOnly" to the CKEDITOR.style class? And then modify the style and find plugins accordingly?
comment:5 follow-up: 6 Changed 13 years ago by
Component: | General → Core : Styles |
---|
Find highlight is current done through styling in all browsers, while actually IE is the only browser that requires it (for not supporting selection mark without holding focus), highlight in the rest of browsers should be simplified by just making a plain selection, which will be free of the read-only styling limitation.
comment:6 Changed 13 years ago by
Replying to garry.yao:
Find highlight is current done through styling in all browsers, while actually IE is the only browser that requires it (for not supporting selection mark without holding focus), highlight in the rest of browsers should be simplified by just making a plain selection, which will be free of the read-only styling limitation.
How would we handle it on IE at this point?
Changed 13 years ago by
Attachment: | 6957.patch added |
---|
comment:7 follow-up: 9 Changed 13 years ago by
Owner: | set to Garry Yao |
---|---|
Status: | confirmed → review |
Vote for using also native selection on IE to present, the only sacrifice is that focus will be moved out of dialog temporarily when displaying the highlight.
comment:9 Changed 13 years ago by
Status: | review → review_failed |
---|
Replying to garry.yao:
Vote for using also native selection on IE to present, the only sacrifice is that focus will be moved out of dialog temporarily when displaying the highlight.
This is not an acceptable solution. It breaks the keyboard navigation on the dialog as well as bringing accessibility issues.
Changed 13 years ago by
Attachment: | 6957_2.patch added |
---|
comment:11 Changed 13 years ago by
Status: | review → review_passed |
---|
comment:12 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed with [7211].
As reported in #7049, using the following code:
results in a javascript error: