Opened 7 years ago

Closed 6 years ago

#6957 closed Bug (fixed)

Find is not highlighting the word in read-only blocks

Reported by: Satya Minnekanti Owned by: Garry Yao
Priority: Normal Milestone:
Component: Core : Styles Version: 3.5
Keywords: IBM Cc: Damian, joek, James Cunningham

Description

To reproduce the defect:

  1. copy the following code and paste it in to source
    <p >
    	first editable paragraph.</p>
    <p contenteditable = "false" >
    	first non editable paragraph.</p>
    <p contenteditable = "false" >
    	second non editable paragraph.</p>
    <p>
    	second editable paragraph.</p>
    
  1. click on Find icon and enter the word non in find what field and click find button.

Expected Result:

non word in the first non editable paragraph should be highlighted.

Expected Result:

Find is not highlighting the non word in the first non editable but when we close the Find and Replace dialog you will see the word getting highlighted.

Attachments (2)

6957.patch (5.5 KB) - added by Garry Yao 6 years ago.
6957_2.patch (3.3 KB) - added by Garry Yao 6 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 7 years ago by Sa'ar Zac Elias

Status: newconfirmed
Version: 3.43.5

comment:2 Changed 6 years ago by Wiktor Walc

Cc: james c added; James removed

As reported in #7049, using the following code:

<p contenteditable="false">inside read-only paragraph</p>

results in a javascript error:

Message: currentNode is null 
Line: 455
URI: /ckeditor/_source/plugins/styles/plugin.js

comment:3 Changed 6 years ago by Wiktor Walc

Cc: James Cunningham added; james c removed

comment:4 Changed 6 years ago by typeof

What do you think about adding a property called something like "appliedToReadOnly" to the CKEDITOR.style class? And then modify the style and find plugins accordingly?

comment:5 Changed 6 years ago by Garry Yao

Component: GeneralCore : Styles

Find highlight is current done through styling in all browsers, while actually IE is the only browser that requires it (for not supporting selection mark without holding focus), highlight in the rest of browsers should be simplified by just making a plain selection, which will be free of the read-only styling limitation.

comment:6 in reply to:  5 Changed 6 years ago by Frederico Caldeira Knabben

Replying to garry.yao:

Find highlight is current done through styling in all browsers, while actually IE is the only browser that requires it (for not supporting selection mark without holding focus), highlight in the rest of browsers should be simplified by just making a plain selection, which will be free of the read-only styling limitation.

How would we handle it on IE at this point?

Changed 6 years ago by Garry Yao

Attachment: 6957.patch added

comment:7 Changed 6 years ago by Garry Yao

Owner: set to Garry Yao
Status: confirmedreview

Vote for using also native selection on IE to present, the only sacrifice is that focus will be moved out of dialog temporarily when displaying the highlight.

comment:8 Changed 6 years ago by Garry Yao

Ticket Test:
run OR view source.

Last edited 6 years ago by Garry Yao (previous) (diff)

comment:9 in reply to:  7 Changed 6 years ago by Frederico Caldeira Knabben

Status: reviewreview_failed

Replying to garry.yao:

Vote for using also native selection on IE to present, the only sacrifice is that focus will be moved out of dialog temporarily when displaying the highlight.

This is not an acceptable solution. It breaks the keyboard navigation on the dialog as well as bringing accessibility issues.

Changed 6 years ago by Garry Yao

Attachment: 6957_2.patch added

comment:10 Changed 6 years ago by Garry Yao

Status: review_failedreview

Ticket tests updated.

comment:11 Changed 6 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

comment:12 Changed 6 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [7211].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy