Opened 7 years ago

Closed 6 years ago

#7073 closed Bug (fixed)

Image dialog should not allow zero for width and height fields

Reported by: Satya Minnekanti Owned by: Sa'ar Zac Elias
Priority: Normal Milestone: CKEditor 3.5.3
Component: General Version: 3.0
Keywords: IBM Cc: Damian, James Cunningham

Description (last modified by Wiktor Walc)

Image dialog allows zero to be entered for image width and height. When zero is entered the image is not visible and it is difficult to select and edit the image's properties.

The Image dialog also allows zero to be entered for Horizontal Space, Vertical Space and Border. A value of zero does not cause a visual effect, but an inline style is applied. The inline style should not be applied if it has no effect.

Either validation should not allow a value of zero, or zero can be allowed but it results in no inline style being applied.

Note: Microsoft Word does not allow a value of zero for image width and height.

Attachments (1)

7073.patch (1.2 KB) - added by Sa'ar Zac Elias 7 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 7 years ago by Wiktor Walc

Status: newconfirmed

comment:2 Changed 7 years ago by Wiktor Walc

Version: 3.0

comment:3 Changed 7 years ago by Alfonso Martínez de Lizarrondo

As I said previously, a zero value in those attributes besides width and height is perfectly valid, it has the effect of setting those attributes or styles to 0 overriding the default.

comment:4 Changed 7 years ago by Wiktor Walc

Description: modified (diff)

I have corrected the description so that this ticket could remain valid. The other attributes were discussed earlier in #6488 as Alfonso already mentioned, 0 make sense there.

Changed 7 years ago by Sa'ar Zac Elias

Attachment: 7073.patch added

comment:5 Changed 7 years ago by Sa'ar Zac Elias

Owner: set to Sa'ar Zac Elias
Status: confirmedreview

comment:6 Changed 6 years ago by Wiktor Walc

Milestone: CKEditor 3.5.3

comment:7 Changed 6 years ago by Garry Yao

Status: reviewreview_passed

comment:8 Changed 6 years ago by Sa'ar Zac Elias

Resolution: fixed
Status: review_passedclosed

Fixed with [6555].

comment:9 Changed 6 years ago by Satya Minnekanti

when we add Zero for width or height it is showing an alert, but when user press OK button on Alert dialog, Image properties dialog getting closed & focus going back to editor body, instead of getting focus back to the Image Properties dialog. This needs to be fixed.

comment:10 Changed 6 years ago by Garry Yao

Resolution: fixed
Status: closedreopened

comment:11 Changed 6 years ago by Garry Yao

Resolution: fixed
Status: reopenedclosed

Post fixing with [6589].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy