Opened 10 years ago

Closed 5 years ago

#750 closed Bug (wontfix)

Comment tags around inline styles disable styles

Reported by: severy@… Owned by:
Priority: Normal Milestone:
Component: General Version: SVN (FCKeditor) - Retired
Keywords: Cc: lizl@…, severy@…, liuspider@…

Description (last modified by Martin Kou)

If style definitions are enclosed within comment tags, they are ignored by the editor. You can see an example of this with the following HTML:

<style type="text/css" media="screen"><!--
p {
color: #333;
font-size: 12px;
font-family: Arial, Helvetica, Geneva, Swiss,
SunSans-Regular }
td {
color: #333;
font-size: 12px;
font-family: Arial, Helvetica, Geneva, Swiss,
SunSans-Regular }
a { color: #c33; font-size: 13px; font-weight: bold;
text-decoration: none }
a:hover {
color: black }
--></style>

In the web browser, the above style definitions work fine. When the content was loaded into the editor, however, the styles are ignored because they are encased in the comment tags.


Moved from SF:
http://sourceforge.net/tracker/index.php?func=detail&aid=1511456&group_id=75348&atid=543653

Attachments (1)

750.patch (610 bytes) - added by Wiktor Walc 9 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 10 years ago by Martin Kou

Description: modified (diff)
Reporter: changed from Martin Kou to severy@…

I'd like to see this fixed as well. Any plans to fix it soon?


Moved from SF. Original poster: lizl

Yes, fckeditor definitely supports inline styles. I implemented a workaround to the above problem by stripping out the comment tags before passing the content to the editor, but it would be preferable if the editor handled the comment tags cleanly.


Moved from SF. Original poster: severy

does fckeditor support <style> at all? I assume not


Moved from SF. Original poster: liuspider

comment:2 Changed 9 years ago by Wojciech Olchawa

Resolution: wontfix
Status: newclosed

Hi!

The editor doesn't support inline styles, however you can apply your own stylesheet by using EditorAreaCSS configuration.

| EditorAreaCSS

comment:3 Changed 9 years ago by Wojciech Olchawa

Resolution: wontfix
Status: closedreopened

comment:4 Changed 9 years ago by Wojciech Olchawa

Keywords: Confirmed added; SF removed

Sorry for my previous post. I misunderstood the problem. Definitely FCKeditor supports inline styles.

Reading styles inside a comment should be working so I can of course confirm this bug.

comment:5 Changed 9 years ago by Wojciech Olchawa

Version: SVN

Changed 9 years ago by Wiktor Walc

Attachment: 750.patch added

comment:6 Changed 9 years ago by Wiktor Walc

Keywords: Review? added

I really doubt that my patch is appropriate for this problem... but why not try anyway? ;-)

Feel free to "Review-" :-)

comment:7 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

The proposed patch will fail in the following cases:

<!-- -- -->
<!--a-->

comment:8 Changed 7 years ago by Frederico Caldeira Knabben

Keywords: Confirmed removed
Status: reopenedconfirmed

comment:9 Changed 5 years ago by Jakub Ś

Resolution: wontfix
Status: confirmedclosed

FCKeditor is no longer supported and and CKEditor has this issue reported here #8129

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy