BIDI: Pressing decrease indent on a RTL list item causes a change in language direction

[James Cunningham]

Steps to reproduce the defect:

1. Open the Ajax sample.

2. Click on the RTL button in the toolbar.

3. Create a bulleted/numbered list.

4. Apply a paragraph format (e.g. Heading 1) to one of the list items.

5. Place the cursor in the list item that the paragraph format was applied to & click on the decrease indent button in the toolbar.

Expected: The number/bullet is removed from the list item and it remains RTL.

Actual: The number/bullet is removed from the list item but the langauge direction changes to LTR.

[Jakub Ś]

Confirmed from CKEditor 3.4

[Garry Yao]

​http://ckeditor.t/tt/7907/1.html

[Frederico Caldeira Knabben]

The following tests are failing with this patch:
​http://ckeditor.t/tt/6461/1.html
​http://ckeditor.t/tt/7645/3.html

[Frederico Caldeira Knabben]

Btw, it seems to be a wrong commit on t/7907.

[Garry Yao]

I would like to propose a re-fix to #6461, otherwise it would be hard to live with the fix here, in the sense that, when the paragraph to convert is already styled, then the block should be preserved in list item, this makes makes no visual difference from previous, while it eliminate any further troubles to inherit styles from the list item later, thus when a list item is removed, its owning styles just gone, but not the content styles.

[Frederico Caldeira Knabben]

This one is now falling:
​http://ckeditor.t/tt/4450/1.html

Would you mind doing a full test run before sending the next patch?

[Garry Yao]

Ok, a full run shows that #4450 tc is the only that need to be updated to reflect the new behavior.

[Frederico Caldeira Knabben]

Replying to garry.yao:

Ok, a full run shows that #4450 tc is the only that need to be updated to reflect the new behavior.

I don't see this change on t/7907. Has it been committed somewhere else?

[Frederico Caldeira Knabben]

Unfortunately enforcing <p> blocks on alignment operations is something to avoid. It brings important behavioral changes to the editor in both layout (e.g. margins for <p>) and semantics aspects.

Because of the above, the changes proposed for the ​#4450 tt are to be reverted.

[Garry Yao]

New patch now copy/merge list item styles to content blocks when removed.

New ticket tcs are added to cover these cases.

[Frederico Caldeira Knabben]

The following new test is not passing:
​http://ckeditor.t/tt/7657/1.html

[Garry Yao]

Fixed with [7419].

[Garry Yao]

Ticket test fails IE8, post fixing with [7425].