Opened 14 years ago
Closed 13 years ago
#7908 closed Bug (fixed)
IE: Unlink option is not always available from the context menu when right clicking on a link
Reported by: | James Cunningham | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.6.2 |
Component: | General | Version: | 3.6 |
Keywords: | IBM IE | Cc: | Damian, Teresa Monahan, Satya Minnekanti |
Description
Steps to reproduce the defect:
- Open the Ajax sampe in IE.
- Paste the following URL into the editor http://nightly.ckeditor.com/
- Right click on the link to display the context menu.
Expected: The context menu is displayed and it contains paste, edit link and unlink
Actual: The context menu is displayed but it only contains paste and edit link. The unlink option is missing.
Note: If you right click on the link again the unlink option is displayed in the context menu.
Attachments (2)
Change History (10)
comment:1 Changed 14 years ago by
Status: | new → confirmed |
---|---|
Version: | 3.6.1 (SVN - trunk) → 3.6 |
comment:2 Changed 14 years ago by
Note: when the caret is inside of a link then the unlink option is shown fine.
comment:3 Changed 14 years ago by
And the following change is the direct cause of this problem: http://dev.ckeditor.com/browser/CKEditor/trunk/_source/plugins/link/dialogs/link.js?rev=6904
Could you please give me a hint where I can find the rationale for this change?
Changed 13 years ago by
Attachment: | 7908.patch added |
---|
comment:4 Changed 13 years ago by
Owner: | set to Garry Yao |
---|---|
Status: | confirmed → review |
I'm not sure it's related to the link dialog change, the culprit is that menu item will query the associated command state before getting added, so we need to make sure all commands state are updated in advance.
comment:5 Changed 13 years ago by
Oh, I'm very sorry, I pasted incorrect link :(
I meant this one http://dev.ckeditor.com/changeset/6904/CKEditor/trunk/_source/plugins/menu/plugin.js
Changed 13 years ago by
Attachment: | 7908_2.patch added |
---|
comment:7 Changed 13 years ago by
Milestone: | → CKEditor 3.6.2 |
---|---|
Status: | review → review_passed |
Please add a space before "?" when committing.
comment:8 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed with [7214].
True from CKEditor 3.6 revision [6904]