Opened 12 years ago

Closed 11 years ago

#7908 closed Bug (fixed)

IE: Unlink option is not always available from the context menu when right clicking on a link

Reported by: James Cunningham Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.6.2
Component: General Version: 3.6
Keywords: IBM IE Cc: Damian, Teresa Monahan, Satya Minnekanti

Description

Steps to reproduce the defect:

  1. Open the Ajax sampe in IE.
  1. Paste the following URL into the editor http://nightly.ckeditor.com/
  1. Right click on the link to display the context menu.

Expected: The context menu is displayed and it contains paste, edit link and unlink

Actual: The context menu is displayed but it only contains paste and edit link. The unlink option is missing.

Note: If you right click on the link again the unlink option is displayed in the context menu.

Attachments (2)

7908.patch (596 bytes) - added by Garry Yao 11 years ago.
7908_2.patch (621 bytes) - added by Garry Yao 11 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 12 years ago by Jakub Ś

Status: newconfirmed
Version: 3.6.1 (SVN - trunk)3.6

True from CKEditor 3.6 revision [6904]

comment:2 Changed 11 years ago by typeof

Note: when the caret is inside of a link then the unlink option is shown fine.

comment:3 Changed 11 years ago by typeof

And the following change is the direct cause of this problem: http://dev.ckeditor.com/browser/CKEditor/trunk/_source/plugins/link/dialogs/link.js?rev=6904

Could you please give me a hint where I can find the rationale for this change?

Changed 11 years ago by Garry Yao

Attachment: 7908.patch added

comment:4 Changed 11 years ago by Garry Yao

Owner: set to Garry Yao
Status: confirmedreview

I'm not sure it's related to the link dialog change, the culprit is that menu item will query the associated command state before getting added, so we need to make sure all commands state are updated in advance.

comment:5 Changed 11 years ago by typeof

Oh, I'm very sorry, I pasted incorrect link :(

I meant this one http://dev.ckeditor.com/changeset/6904/CKEditor/trunk/_source/plugins/menu/plugin.js

comment:6 Changed 11 years ago by Garry Yao

Manual Ticket Test added:
run OR view source.

Changed 11 years ago by Garry Yao

Attachment: 7908_2.patch added

comment:7 Changed 11 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.6.2
Status: reviewreview_passed

Please add a space before "?" when committing.

comment:8 Changed 11 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [7214].

Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy