Opened 7 years ago

Last modified 5 years ago

#7940 review Bug

Fake object can be styled as images

Reported by: Sa'ar Zac Elias Owned by: Jakub Ś
Priority: Normal Milestone:
Component: General Version: 3.0
Keywords: Cc:

Description (last modified by Sa'ar Zac Elias)

  • Insert a flash object, with some height and width.
  • Click on the image.
  • Open the styles combo and see that image styling options are available.
  • Click on "image on the right". See that the image's dimensions get reset.

Attachments (1)

7940.patch (634 bytes) - added by Jakub Ś 5 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 7 years ago by Sa'ar Zac Elias

Description: modified (diff)

comment:2 Changed 7 years ago by Jakub Ś

Status: newconfirmed
Version: 3.0

The size stays the same but the image (placeholder) representing flash gets resized.

This has been true from version 3.0;

NOTE: I you want to paste ready flash in source mode then the image representing it will be visible in WYSIWYG only from version 3.5.3.

comment:3 Changed 5 years ago by Jakub Ś

Fix to this issue might be:

In CKEditor GIT reporsitory (https://github.com/ckeditor/ckeditor-dev) go to:
ckeditor4\plugins\stylescombo\plugin.js
Line 155

change

if ( !counter[ CKEDITOR.STYLE_OBJECT ] )
this.hideGroup( lang[ 'panelTitle' + String( CKEDITOR.STYLE_OBJECT ) ] );

to

if ( !counter[ CKEDITOR.STYLE_OBJECT ] || ( element && element.data( 'cke-realelement' ) ) )
							this.hideGroup( lang[ 'panelTitle' + String( CKEDITOR.STYLE_OBJECT ) ] );
Last edited 5 years ago by Jakub Ś (previous) (diff)

comment:4 Changed 5 years ago by Jakub Ś

Owner: set to Jakub Ś
Status: confirmedassigned

Changed 5 years ago by Jakub Ś

Attachment: 7940.patch added

comment:5 Changed 5 years ago by Jakub Ś

Status: assignedreview
Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy