Opened 10 years ago

Closed 10 years ago

#805 closed Bug (fixed)

Keystroke bypass disabled buttons in source mode

Reported by: neym@… Owned by: Alfonso Martínez de Lizarrondo
Priority: Normal Milestone: FCKeditor 2.6
Component: UI : Source View Version:
Keywords: SF Confirmed Review+ Cc:

Description

When in source mode, certain functions are grayed out (find, font color, etc). When these functions are assigned to a keystroke they are still accessible via that keystroke.

To reproduce:

  • Assign a keystroke to Find in FCKConfig.
  • Press that keystroke while in source mode.

Result: Firebug reports error "oEditor.FCK.EditorDocument has no properties"

---

Noticed also that there are a lot of functions (add bullets, etc) that aren't grayed out in the button bar that also cause the same Firebug error report.

--Michael


Moved from SF:
http://sourceforge.net/tracker/index.php?func=detail&aid=1675277&group_id=75348&atid=543653

Attachments (1)

805.patch (718 bytes) - added by Alfonso Martínez de Lizarrondo 10 years ago.
Proposed SVN patch

Download all attachments as: .zip

Change History (8)

comment:1 Changed 10 years ago by Martin Kou

Reporter: changed from Martin Kou to neym@…

comment:2 Changed 10 years ago by Alfonso Martínez de Lizarrondo

Component: GeneralUI : Source View

comment:3 Changed 10 years ago by Wojciech Olchawa

Keywords: Confirmed added

Confirmed

IE and IE7: the assigned keystrokes open the function window e.g. find/replace in the source view and the following error shows:

'oEditor.FCK.EditorDocument.body' is null or not and object.

Not all of the functions behave in this way. Some of them e.g.TextColor are activated when using the keystroke and they appear in random place

FF2 : the assigned keystrokes only open the windows. They don't open menus like e.g.TextColor

There isn't one rule for this bug so it should be further investigated.

Changed 10 years ago by Alfonso Martínez de Lizarrondo

Attachment: 805.patch added

Proposed SVN patch

comment:4 Changed 10 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review? added
Owner: set to Alfonso Martínez de Lizarrondo
Status: newassigned

Thanks to the work done by Martinkou now the commands always return the proper state, so this is very easy to fix.

comment:5 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

Please include the changelog entry.

comment:6 Changed 10 years ago by Frederico Caldeira Knabben

Milestone: FCKeditor 2.6

comment:7 Changed 10 years ago by Alfonso Martínez de Lizarrondo

Resolution: fixed
Status: assignedclosed

Fixed with [1479]

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy