Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#8055 closed Bug (fixed)

Allow captions that include entities to be edited through the dialog

Reported by: Sa'ar Zac Elias Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.6.1
Component: Core : Tables Version: 3.6.1
Keywords: Cc:

Description

FUP of #6663.
It is now impossible to edit html in table captions thorugh the dialog, but we should support entities in there, e.g. non-breaking spaces.

Attachments (3)

8055.patch (863 bytes) - added by Garry Yao 6 years ago.
8055_2.patch (1.8 KB) - added by Garry Yao 6 years ago.
8055_3.patch (1.6 KB) - added by Garry Yao 6 years ago.

Download all attachments as: .zip

Change History (13)

Changed 6 years ago by Garry Yao

Attachment: 8055.patch added

comment:1 Changed 6 years ago by Garry Yao

Component: GeneralCore : Tables
Owner: set to Garry Yao
Status: newreview

comment:2 Changed 6 years ago by Sa'ar Zac Elias

Status: reviewreview_failed

Putting spaces inside the dialog field inserts plain spaces instead of the expected non-breakable spaces.

Changed 6 years ago by Garry Yao

Attachment: 8055_2.patch added

comment:3 Changed 6 years ago by Garry Yao

Status: review_failedreview

Second patch takes care of this, but seems to work in IE only, anyway we can proceed with this which is considered as the correct way and leave other hacks later.

comment:4 Changed 6 years ago by Sa'ar Zac Elias

Status: reviewreview_failed

Actually it doesn't seem to work in any browser, giving a JS error instead.

Changed 6 years ago by Garry Yao

Attachment: 8055_3.patch added

comment:5 Changed 6 years ago by Garry Yao

Status: review_failedreview

comment:6 Changed 6 years ago by Sa'ar Zac Elias

Status: reviewreview_failed

Doesn't work when multiple spaces are in the initial caption text (when creating a table, not editing it).

comment:7 Changed 6 years ago by Garry Yao

Status: review_failedreview

#8075 is opened for the white-spaces issue, please continue to review 8055.patch.

Last edited 6 years ago by Garry Yao (previous) (diff)

comment:8 Changed 6 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

R+ for 8055.patch.

comment:9 Changed 6 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [7057].

comment:10 Changed 6 years ago by Wiktor Walc

Since it was possible to edit such captions in 3.6, I have removed the changelog entry with [7058].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy