IE : Cursor goes to start of editor body when we bring up link dialog using Link tool bar icon & closing Link dialog using OK Button

[Satya Minnekanti]

To reproduce the defect:

1. Open any CK Editor sample and insert a link.

2. Keep cursor inside the link and click on Link icon in the toolbar.

3. See that Link dialog comes up

4. Don't change any values, Close the Link dialog by clicking OK Button.

Expected Result: Link dialog is closed and Link gets selected.

Actual Result: Link dialog is closed but cursor going to start of editor body. This will cause huge inconvenience to users if they want to edit a document with huge content in it.

[Jakub Ś]

Reproducible in IE browsers from CKEditor 3.5.3 rev [6459]

[Garry Yao]

I'd like to find a shortcut workaround for this issue, while it doesn't looks simple, so a bit of drastic change is proposed here, to coordinate the locked selection feature and saved range workaround in IE. The following tickets must be considered when reviewing:

Status: closed (5 matches)

Ticket	Summary	Component	Keywords	Milestone
#4682	Content of any tag with width or height property is not editable in IE7 and IE8	General	Confirmed Review+	CKEditor 3.3
#5280	Vertical scroll bounces up when clicking in-between the vertical scroll bar and the bottom arrow	General	IE	CKEditor 3.4
#5735	Incorrect cursor position when refocusing editor and cursor is in scrolled content	General	IE	CKEditor 3.4
#6083	IE: Selection collapses when inserting special char	General		CKEditor 3.4.2
#6987	IE: insertHtml inserts content at the beginning and ignores the selection	General	IE	CKEditor 3.5.3

[Frederico Caldeira Knabben]

Considering that this is not a recent regressions and that the patch proposes a very drastic change, we'll not be able to accommodate this fix into the 3.6.2.

[Frederico Caldeira Knabben]

A basic test for this issue has been created at t/8345:
​http://ckeditor.t/tt/8345/1.html

Further tests are needed though for all related tickets.

[Garry Yao]

Dt updated to include cursor position check after link creation which should be tackled by this ticket as well.

​http://ckeditor.t/dt/plugins/link/link.html

[Frederico Caldeira Knabben]

I'm not able anymore to properly patch the current trunk. Can you please provide an updated patch for it?

[Garry Yao]

I have simplified the patch, the previous patch is over ambitious for this issue, here the real culprit is that link dialog has somehow touched the dom node so the native range restoring failed to work and since it cancel the locked selection as well, the result cursor is all the way wrong, in addition the patch also addresses the following TC:

1. Load default replacebyclass sample;
2. Put cursor in the middle of the link and open Link dialog;
3. Close the dialog with OK button;

• Actual Result: Cursor position remains;
• Expected : Selection expands to have the entire link selected.

Let me claim that this issue doesn't affect v4, where we have a different strategy to have locked selection, so it's enough to have the patch v3 dedicated.

[Frederico Caldeira Knabben]

Please have the original "Update locked selection because of the normalized text nodes" comment back in place when committing, because it makes it easier to understand the hack being done there.

[Garry Yao]

Fixed with [7384].

[Frederico Caldeira Knabben]

The ​ticket test is failing on all browsers, except IE.

[Garry Yao]

It's a pity that the ticket tc didn't get reviewed, but it's not been normalized in all browsers, so its not a regression.