Opened 13 years ago
Closed 13 years ago
#8855 closed Bug (fixed)
Popup not working on Chrome 18
Reported by: | Sa'ar Zac Elias | Owned by: | Sa'ar Zac Elias |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.6.3 |
Component: | General | Version: | |
Keywords: | Chrome | Cc: |
Description (last modified by )
Not affecting Safari, or Chrome 17 or 19.
Chrome 18 is problematic with moveTo and resizeTo, making the window to not show up.
See this and that.
Since that part of the code is not needed in Chrome 18, I propose to avoid it altogether. Note that WebKit 535 is maintained since Chrome 13 till Chrome 18.
Attachments (2)
Change History (14)
Changed 13 years ago by
Attachment: | 8855.patch added |
---|
comment:1 Changed 13 years ago by
Owner: | set to Sa'ar Zac Elias |
---|---|
Status: | new → review |
comment:2 Changed 13 years ago by
Description: | modified (diff) |
---|
comment:3 Changed 13 years ago by
Status: | review → review_failed |
---|
comment:5 Changed 13 years ago by
Status: | review_failed → review |
---|
I believe that there's a reason this code is there, so to avoid wider testing on this simple issue, I would leave it there. We could definitely consider removing it later, but for now let's make sure we don't cause any new problems.
comment:7 Changed 13 years ago by
Status: | review → review_passed |
---|
comment:8 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed with [7448].
comment:9 Changed 13 years ago by
This appears to be broken again in 20.0.1132.34 beta-m. :/
So if the 7448 workaround was just to work around version 18, hopefully it won't be an issue when 20 is released.
comment:10 Changed 13 years ago by
Wouldn't be quite sure about that: http://code.google.com/p/chromium/issues/detail?id=2091 They restored the old behavior, the issue has been in "Won't fix" status for 4 years and the only comment by chromium devs is "This is by design". Hope you are right, it seems a silly behavior to me.
comment:11 Changed 13 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
I have just checked Chrome 20 and this issue has showed up again in CKEditor and CKFinder.
comment:12 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Sorry for opening already closed ticked.
For Chrome 20 new ticket #9069 was opened.
I wonder if we really need to the chunk of code for popup position, consider that the position is already a cross-browser feature for window.open, so we can simply remove it.