Opened 5 years ago

Closed 5 years ago

#8855 closed Bug (fixed)

Popup not working on Chrome 18

Reported by: Sa'ar Zac Elias Owned by: Sa'ar Zac Elias
Priority: Normal Milestone: CKEditor 3.6.3
Component: General Version:
Keywords: Chrome Cc:

Description (last modified by Sa'ar Zac Elias)

Not affecting Safari, or Chrome 17 or 19.
Chrome 18 is problematic with moveTo and resizeTo, making the window to not show up.
See this and that. Since that part of the code is not needed in Chrome 18, I propose to avoid it altogether. Note that WebKit 535 is maintained since Chrome 13 till Chrome 18.

Attachments (2)

8855.patch (670 bytes) - added by Sa'ar Zac Elias 5 years ago.
popup.patch (967 bytes) - added by luckytp 5 years ago.
Path to fix open popup in chrome

Download all attachments as: .zip

Change History (14)

Changed 5 years ago by Sa'ar Zac Elias

Attachment: 8855.patch added

comment:1 Changed 5 years ago by Sa'ar Zac Elias

Owner: set to Sa'ar Zac Elias
Status: newreview

comment:2 Changed 5 years ago by Sa'ar Zac Elias

Description: modified (diff)

comment:3 Changed 5 years ago by Garry Yao

Status: reviewreview_failed

I wonder if we really need to the chunk of code for popup position, consider that the position is already a cross-browser feature for window.open, so we can simply remove it.

comment:4 Changed 5 years ago by Jakub Ś

#8860 was marked as duplicate.

comment:5 Changed 5 years ago by Sa'ar Zac Elias

Status: review_failedreview

I believe that there's a reason this code is there, so to avoid wider testing on this simple issue, I would leave it there. We could definitely consider removing it later, but for now let's make sure we don't cause any new problems.

comment:6 Changed 5 years ago by Anna Tomanek

#8863 was marked as duplicate.

comment:7 Changed 5 years ago by Garry Yao

Status: reviewreview_passed

comment:8 Changed 5 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [7448].

comment:9 Changed 5 years ago by Matthew

This appears to be broken again in 20.0.1132.34 beta-m. :/

So if the 7448 workaround was just to work around version 18, hopefully it won't be an issue when 20 is released.

comment:10 Changed 5 years ago by lencinhaus

Wouldn't be quite sure about that: http://code.google.com/p/chromium/issues/detail?id=2091 They restored the old behavior, the issue has been in "Won't fix" status for 4 years and the only comment by chromium devs is "This is by design". Hope you are right, it seems a silly behavior to me.

comment:11 Changed 5 years ago by Jakub Ś

Resolution: fixed
Status: closedreopened

I have just checked Chrome 20 and this issue has showed up again in CKEditor and CKFinder.

comment:12 Changed 5 years ago by Jakub Ś

Resolution: fixed
Status: reopenedclosed

Sorry for opening already closed ticked.

For Chrome 20 new ticket #9069 was opened.

Changed 5 years ago by luckytp

Attachment: popup.patch added

Path to fix open popup in chrome

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy