[IE8] Delete key before list item

[Garry Yao]

1. Load the following into editor

   <p>&nbsp;</p>
   <ol>
   	<li>
   		B</li>
   	<li>
   		C</li>
   </ol>
   

2. Place the cursor at the end of first empty paragraph;
3. Press DELETE.

• Actual: The paragraph is deleted but the list items no longer appear as a list (even though li is still displayed on the elements path bar).

It affects IE8 on WinXP only.

[Satya Minnekanti]

Adding myself to cc

[Garry Yao]

Let's have the fix dedicated to list only.

[Garry Yao]

The patch provides handling for DEL key used before a list, to merge with the first list item.

[Frederico Caldeira Knabben]

I had a huge surprise when testing the reported tc. That's definitely not expected.

The current behavior we have with Firefox is the right one, partially. There is still an additional case to fix:

• In an empty paragraph, the paragraph gets deleted and the caret moves to the start of the list (reported tc).

• In a non-empty paragraph AND the first list item doesn't have a sublist, that list item gets merged into the paragraph.

• Any other case does nothing.

We need tests for all the above points to be able to proceed accordingly.

[Garry Yao]

The review has to be conducted at #9129 instead of here.

[Garry Yao]

Fixed by #9129.

[Satya Minnekanti]

In IE7, IE9/IE8 Compat View, when we press Delete button empty paragraph gets deleted but first list item becomes a paragraph Pls re-open the ticket and fix this issue

[Jakub Ś]

@satya comment is correct. TC from comment 10 is still reproducible.

[Garry Yao]

In short, we need to make range::checkStart(End)OfBlock return TRUE for the following case, ignoring the filler node, in IE:

<p>&nbsp;^</p>
AND
<p>^&nbsp;</p>

Opened t/9152 for test.

[Frederico Caldeira Knabben]

Correct me if I'm wrong, but the current tests are totally valid. If anything else needs to be tested, additional tests must be added, instead of changing the current ones to fit the patch needs.

[Garry Yao]

You're right, previous patch breaks one original TC in gecko

<p><br />^</p> // => start & end of block

And didn't consider one important TC in IE:

<p>foo|&nbsp;</p> // single text node => end of block

The tests are squashed for easier review.

[Garry Yao]

Fixed with [7616].

[Satya Minnekanti]

This is not properly fixed. 2nd scenario mentioned by fred in ​https://dev.ckeditor.com/ticket/9152#comment:6 still not working. Please re-open this ticket

1. Load the following in to Editor

<p>
	First Non-Empty Paragrapgh</p>
<ol>
	<li>
		first list item with no sub-lists</li>
	<li>
		second list item with no sublists</li>
</ol>

2. Place cursor at end of non-empty Paragraph & press Delete

Expected Result: First list item gets merged in to Paragraph and Numbered list remains with one list item.

Actual Result: First list item not merged in to the Paragraph, Numbered list removed , but we still see li in elements path bar, cursor stays at start of first list item. If you switch to HTML Source and then back to Rich Text you will see that Numbered list gets changed to Bulleted list.

[Garry Yao]

It's a pity that it's just IE8@XP doesn't behave well for merging the list item, but the patch would expanded the fix to other browsers as well, considering the current level of supported TC.

Updated keystrokes tests at branch t/9252 accordingly.

[Garry Yao]

Fixed with [7620].