Opened 7 years ago

Closed 7 years ago

#9381 closed Bug (fixed)

[IE8] Image dialog fails to remove border

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.6.5
Component: General Version: 3.6.5
Keywords: Cc:

Description

  1. Load the following source in IE8:
    <p>[<img src="http://dev.ckeditor.com/chrome/site/logo-ckeditor-dev.png" border="1" />]</p>
    
  2. Open Image dialog, then empty the border field value
  3. Confirm the dialog and check the source.
  • Actual:
    <p><img src="http://dev.ckeditor.com/chrome/site/logo-ckeditor-dev.png" style="border-bottom: 1px solid; border-left: 1px solid; border-top: 1px solid; border-right: 1px solid" /></p>
    

Attachments (2)

9381.patch (2.7 KB) - added by Garry Yao 7 years ago.
9381_2.patch (2.7 KB) - added by Garry Yao 7 years ago.

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by Garry Yao

Attachment: 9381.patch added

comment:1 Changed 7 years ago by Garry Yao

Owner: set to Garry Yao
Status: newreview

comment:2 Changed 7 years ago by Frederico Caldeira Knabben

Status: reviewreview_failed

The only problem in the patch is the lack of attention to the coding style (curly braces) and the unnecessary switch/case block at line 1781 (should be "if"). For the rest, the idea is good.

Changed 7 years ago by Garry Yao

Attachment: 9381_2.patch added

comment:3 Changed 7 years ago by Garry Yao

Status: review_failedreview

Updated with coding styles fixes, there's a limitation for thecurr impl, that it doesn't properly expanding for shorthands like "border-width" and "border-top", but let's leave it simply for now.

comment:4 Changed 7 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

comment:5 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [7623].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy