Opened 12 years ago
Closed 12 years ago
#9423 closed Task (fixed)
Implement Moono as our default skin
Reported by: | Frederico Caldeira Knabben | Owned by: | Olek Nowodziński |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.0 |
Component: | UI : Skins | Version: | |
Keywords: | Cc: |
Description
"Moono" is the winner of the CKEditor 4 Skin Contest.
Now we need to take the contest submitted files and work on them for their perfection, making this skin the default one in the development code.
Attachments (11)
Change History (20)
comment:1 Changed 12 years ago by
Status: | new → confirmed |
---|
comment:2 Changed 12 years ago by
comment:3 Changed 12 years ago by
Owner: | set to Frederico Caldeira Knabben |
---|---|
Status: | confirmed → assigned |
comment:4 Changed 12 years ago by
Owner: | changed from Frederico Caldeira Knabben to Olek Nowodziński |
---|
comment:5 Changed 12 years ago by
Status: | assigned → review |
---|
A pre-review of t/9423@cksource is requested to speed up development. Thus:
- This branch still has no good IE7 support.
- HC hasn't been tested yet...
- ...as well as quirks.
Important things to consider:
- Changes in core/skin.js
- Changes in panel plugin
- Decent modern-browser support.
- Decent UI Color support.
If something's wrong, screenshots are welcome.
Changed 12 years ago by
Attachment: | ie9DialogFooterNoTopLine.png added |
---|
Changed 12 years ago by
Attachment: | colorPickerNarrowInputs.png added |
---|
Changed 12 years ago by
Attachment: | ie7DialogIssues.png added |
---|
Changed 12 years ago by
Attachment: | IEUIcolorTabsActive.png added |
---|
comment:7 Changed 12 years ago by
My first impression from Chrome is that skin is nearly finished. I've found few minor issues:
Beige borders around smiles in smiles dialog.- No vertical space between selected color and its hex representation in color picker (scr1).
No visual partition between characters in special characters dialog.Disabled inputs are too dark (scr2).There's a strange shadow under the text in buttons inside dialogs (scr2).- Text in native select is too low (scr3).
- Blue links in about dialog don't look good.
Changed 12 years ago by
Changed 12 years ago by
Changed 12 years ago by
comment:8 Changed 12 years ago by
Few more issues:
- (scr4) On Firefox
box-shadow: inset
is much stronger than on Chrome. I like the Chrome's version more, because it's cleaner. What's more - this shadow is rendered only... sometimes (scr7). It's definitely FF's bug but maybe we can bypass it. - (scr5) Again on FF box shadow is too strong - much stronger than on Chrome.
(scr6) Format combo reacted on hover even though I was in source mode.There's a second issue with combos - on Chrome they have separate "active" style (when mouse button is down), on FF now. And when SCAYT menu is opened it has this "active" style, but when style combos are opened they have normal style.On IE8 cursor isn't change over buttons in the dialog footer (... ok, it is but not if over text).
Changed 12 years ago by
Changed 12 years ago by
Changed 12 years ago by
Changed 12 years ago by
comment:9 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | review → closed |
Branch t/9423 closed with a commit merged into master.
Further Moono development and fixing goes here.
Branch t/9423@cksource started with the original Moono files.