Opened 12 years ago

Closed 12 years ago

#9440 closed Bug (fixed)

[Opera&ThemedUI] Font size cannot be applied

Reported by: Piotrek Koszuliński Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 4.0
Component: UI : Floating Panel Version: 4.0
Keywords: Cc:

Description

  1. Open any sample themedui sample.
  2. Select some text.
  3. Open font-size combo and pick one value.
  • Expected: obvious.
  • Actual: nothing happened.

Change History (6)

comment:1 Changed 12 years ago by Piotrek Koszuliński

Owner: set to Piotrek Koszuliński
Status: new → assigned

comment:2 Changed 12 years ago by Piotrek Koszuliński

First bad commit: ​https://github.com/ckeditor/ckeditor-dev/commit/14f3062 (fix for #9258).

Last edited 12 years ago by Piotrek Koszuliński (previous) (diff)

comment:3 Changed 12 years ago by Garry Yao

Owner: changed from Piotrek Koszuliński to Garry Yao
Status: assigned → review

Pushed t/9440 for review, it removed the preset value when clicking on combo item, considering that the value is to be determined by each individual plugin (on selection change event).

#9258 is to be checked when reviewing.

Last edited 12 years ago by Piotrek Koszuliński (previous) (diff)

comment:4 Changed 12 years ago by Garry Yao

Component: General → UI : Floating Panel

comment:5 Changed 12 years ago by Piotrek Koszuliński

Status: review → review_passed

I came up with the same solution yesterday and I also checked that #9258 isn't happening again (not possible on Opera because of strange things happening to selection - that may be related to #9459), so R+.

Last edited 12 years ago by Piotrek Koszuliński (previous) (diff)

comment:6 Changed 12 years ago by Piotrek Koszuliński

Resolution: → fixed
Status: review_passed → closed

Masterised: ​https://github.com/ckeditor/ckeditor-dev/commit/a35c948

Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy