Opened 6 years ago

Closed 6 years ago

#9540 closed Bug (fixed)

[HC] Missing hover/focus style on UI

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 4.0
Component: UI : Toolbar Version: 4.0
Keywords: HC Cc:

Description

The following UI items are missing in the default skin, for proper styling when hovered/focused

  1. All toolbar items;
  2. Elements path bar items;
  3. Dialog fields;

Attachments (3)

hc1.png (20.8 KB) - added by Piotrek Koszuliński 6 years ago.
hc2.png (22.4 KB) - added by Piotrek Koszuliński 6 years ago.
hc3.png (29.1 KB) - added by Piotrek Koszuliński 6 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 6 years ago by Garry Yao

Status: newconfirmed

Besides of the ticket tc, there're other minor issues found needed to be fixed in this ticket:

  • Resizer is not properly displayed as triangle;
  • [Firefox] Dialog select field is missing border;
  • [IE7] Dialog text field border get doubled;
  • Hover menu items enlarges the element size;
  • No hover/focus style for listbox item;
Last edited 6 years ago by Garry Yao (previous) (diff)

comment:2 Changed 6 years ago by Garry Yao

Owner: set to Garry Yao
Status: confirmedassigned

comment:3 Changed 6 years ago by Garry Yao

Status: assignedreview

Opened t/9540 for review.

comment:4 Changed 6 years ago by Piotrek Koszuliński

Status: reviewreview_failed

All issues are fixed, but I think that something's wrong with inputs. See that inputs don't fill entire outer container.

Master:

IE9@t/9540:

FF@t/9540:

Last edited 6 years ago by Piotrek Koszuliński (previous) (diff)

Changed 6 years ago by Piotrek Koszuliński

Attachment: hc1.png added

Changed 6 years ago by Piotrek Koszuliński

Attachment: hc2.png added

Changed 6 years ago by Piotrek Koszuliński

Attachment: hc3.png added

comment:5 Changed 6 years ago by Garry Yao

Status: review_failedreview

Fixed the border enlarged issue, a small addition is necessary on dialogui plugin, to give selection field a container element.

comment:6 Changed 6 years ago by Piotrek Koszuliński

Status: reviewreview_passed

comment:7 Changed 6 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy