Context Navigation

← Previous Ticket
Next Ticket →

#9540 closed Bug (fixed)

[HC] Missing hover/focus style on UI

Reported by:	Garry Yao	Owned by:	Garry Yao
Priority:	Normal	Milestone:	CKEditor 4.0
Component:	UI : Toolbar	Version:	4.0
Keywords:	HC	Cc:

Description

The following UI items are missing in the default skin, for proper styling when hovered/focused

All toolbar items;
Elements path bar items;
Dialog fields;

Attachments (3)

hc1.png (20.8 KB) - added by Piotrek Koszuliński 11 years ago.
hc2.png (22.4 KB) - added by Piotrek Koszuliński 11 years ago.
hc3.png (29.1 KB) - added by Piotrek Koszuliński 11 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 11 years ago by Garry Yao

Status:	new → confirmed

Besides of the ticket tc, there're other minor issues found needed to be fixed in this ticket:

Resizer is not properly displayed as triangle;
[Firefox] Dialog select field is missing border;
[IE7] Dialog text field border get doubled;
Hover menu items enlarges the element size;
No hover/focus style for listbox item;

Last edited 11 years ago by Garry Yao (previous) (diff)

comment:2 Changed 11 years ago by Garry Yao

Owner:	set to Garry Yao
Status:	confirmed → assigned

comment:3 Changed 11 years ago by Garry Yao

Status:	assigned → review

Opened t/9540 for review.

comment:4 Changed 11 years ago by Piotrek Koszuliński

Status:	review → review_failed

All issues are fixed, but I think that something's wrong with inputs. hc1.png is state on master, hc2.png on IE9, hc3.png on FF. See that inputs don't fill entire outer container.

Version 0, edited 11 years ago by Piotrek Koszuliński (next)

Changed 11 years ago by Piotrek Koszuliński

Attachment:	hc1.png added

Changed 11 years ago by Piotrek Koszuliński

Attachment:	hc2.png added

Changed 11 years ago by Piotrek Koszuliński

Attachment:	hc3.png added

comment:5 Changed 11 years ago by Garry Yao

Status:	review_failed → review

Fixed the border enlarged issue, a small addition is necessary on dialogui plugin, to give selection field a container element.

comment:6 Changed 11 years ago by Piotrek Koszuliński

Status:	review → review_passed

comment:7 Changed 11 years ago by Garry Yao

Resolution:	→ fixed
Status:	review_passed → closed

Fixed on master with:

https://github.com/ckeditor/ckeditor-dev/commit/ec1fb4ee541e57703a6092d8e556793925cfb3a0

Note: See TracTickets for help on using tickets.

Download in other formats: