Opened 12 years ago
Closed 11 years ago
#9654 closed Bug (fixed)
CKE 4.x - Problems with IE10 Quirks mode
| Reported by: | Jakub Ś | Owned by: | Piotr Jasiun |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.2.1 |
| Component: | General | Version: | 4.0 |
| Keywords: | IE10 | Cc: |
Description
- Open attached sample in IE10 (You need to copy it to samples folder)
- Switch to source and back
Results:
- Notice that buttons still have greyed out style (like in source mode)
- When you click on toolbar button -dialog shows up but JS error is also thrown.
Message: Unable to get property '0' of undefined
Line: 1108
URI: /ckeditor4/plugins/dialog/plugin.js
Attachments (1)
Change History (14)
Changed 12 years ago by
| Attachment: | test_quirks.html added |
|---|
comment:1 Changed 12 years ago by
| Status: | new → confirmed |
|---|
comment:2 Changed 12 years ago by
| Milestone: | → CKEditor 4.0.1 |
|---|
comment:3 Changed 12 years ago by
| Milestone: | CKEditor 4.0.1 |
|---|
comment:4 Changed 12 years ago by
Quick test proved that I wasn't right that situation looks so bad :). New IE10's QM is pretty close to std mode, so we just need to modify env.js, so editor's QM isn't turned on on IE10's QM.
comment:5 Changed 11 years ago by
| Milestone: | → CKEditor 4.2.1 |
|---|
comment:7 Changed 11 years ago by
| Owner: | set to Piotr Jasiun |
|---|---|
| Status: | confirmed → assigned |
comment:8 Changed 11 years ago by
| Status: | assigned → review |
|---|
Fixed. env.ie6Compat is now false for quirks mode in IE10 and everything seems to be fine.
comment:9 Changed 11 years ago by
| Status: | review → review_failed |
|---|
env.ie6Compat = version < 7 || (env.quirks && version != 10);
IE11 will not have QM? I guess it will.
comment:10 Changed 11 years ago by
I'm not sure if IE11 will still have env.ie == true, but good point. I changed it t/9654.
comment:11 Changed 11 years ago by
| Status: | review_failed → review |
|---|
comment:12 Changed 11 years ago by
| Status: | review → review_passed |
|---|
I rebased the branch o master and fixed code-style. The UI still doesn't look perfect but the editor is working with this fix.
comment:13 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Merged into master git:0fb7afe
Note: See
TracTickets for help on using
tickets.
Situation looks bad. It turns out that IE10 has two Quirks Mode - the new one, which is close to standards and which in fact replaced the old one, because IE10 turns it on when there's no Doctype. And old QM (IE5 mode) which needs meta tag to be turned on.
More info:
Thanks to this brilliant decision editor tries to work in IE5 mode on browser that is in neither IE5 nor standards mode. I haven't checked that, but I guess that we'd need to handle completely new bugs set and we're definitely not going to try to do this now.