Opened 7 years ago

Closed 7 years ago

#9689 closed Bug (fixed)

Div container command cause JS error

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 4.0
Component: Core : Styles Version: 4.0
Keywords: Cc:

Description (last modified by Garry Yao)

Div container will throw JS error when opened.

Uncaught TypeError: Cannot call method 'getName' of undefined 

Change History (8)

comment:1 Changed 7 years ago by Garry Yao

Description: modified (diff)
Status: newconfirmed
Summary: [inline] Div container command cause JS errorDiv container command cause JS error

comment:2 Changed 7 years ago by Piotrek Koszuliński

Owner: set to Piotrek Koszuliński
Status: confirmedassigned

comment:3 Changed 7 years ago by Piotrek Koszuliński

First bad commit git:c8b8caa. Unfortunately it just revealed hidden bug.

comment:4 Changed 7 years ago by Piotrek Koszuliński

Status: assignedreview

Pushed t/9689

comment:5 Changed 7 years ago by Garry Yao

Status: reviewreview_failed

Beyond the ticket TC but still a quite basic one - choose any of the style option will cause JS error.

comment:6 in reply to:  5 Changed 7 years ago by Garry Yao

Owner: changed from Piotrek Koszuliński to Garry Yao
Status: review_failedreview

Replying to garry.yao:

Beyond the ticket TC but still a quite basic one - choose any of the style option will cause JS error.

Pushed two commits to address that.

comment:7 Changed 7 years ago by Piotrek Koszuliński

Status: reviewreview_passed

comment:8 Changed 7 years ago by Piotrek Koszuliński

Resolution: fixed
Status: review_passedclosed

Masterised with git:4f213b5

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy