Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#9713 closed New Feature (fixed)

Inline editing Source mode

Reported by: giammin Owned by: Olek Nowodziński
Priority: Normal Milestone: CKEditor 4.1 RC
Component: General Version: 4.0
Keywords: Drupal Cc: wim.leers@…

Description

In inline editing mode Source button is not displayed in toolbar

Change History (17)

comment:1 Changed 7 years ago by giammin

Component: GeneralUI : Toolbar
Keywords: toolbar added

comment:2 Changed 7 years ago by Jakub Ś

Component: UI : ToolbarGeneral
Keywords: inline source toolbar removed
Status: newconfirmed
Type: BugNew Feature

Currently this feature is not available.

We are still thinking about best way for implementing this.

comment:3 Changed 7 years ago by Piotrek Koszuliński

Milestone: CKEditor 4.1
Version: 4.0 Beta4.0 (GitHub - master)

comment:4 Changed 7 years ago by Wim Leers

Cc: wim.leers@… added

I'm certain that Drupal folks will want this feature — this is one of the things that Aloha Editor doesn't have at all and (to my surprise) was apparently a much-wanted, almost a critical feature for power users.

comment:5 Changed 6 years ago by Allen Rowland

I would love to see this feature added. I am drooling over this inline editor, but could really use a source button. Since you are still thinking about the best way to implement this, an idea for one way to do this would be to open a lightbox when you click source and update the element once you click update. That's just an idea, anyways, keep up the great work and thanks for this wonderful product!

comment:6 Changed 6 years ago by Wiktor Walc

Keywords: Drupal added

comment:7 Changed 6 years ago by Viju

Is there any progress on this issue? Any work around available ? Thank you.

comment:8 Changed 6 years ago by Niklas

I'm really hoping for this feature. If you're still wondering how to implement this I suggest source would open in a new dialog with just one OK button to close the dialog.

comment:9 Changed 6 years ago by Frederico Caldeira Knabben

Owner: set to Frederico Caldeira Knabben
Status: confirmedreview

Introduced the new "source" plugin in t/9713@cksource, which makes source editing in a dialog in both framed and inline editing.

comment:10 Changed 6 years ago by Olek Nowodziński

Status: reviewreview_failed
  • Fixed selection issues on dialog close in Firefox, Webkit and IE.
  • New behavior: don't setData if content didn't change - preserve selection in such case.
  • Added sample for source plugin with inline&framed editors to promote it.
  • Created t/9713@tests-v4 with tests for the plugin.

Still broken:

  • IE7&8 (sometimes 9):
    Permission denied  node.js, line 257 character 3
    Invalid argument.  node.js, line 563 character 4
    
    when closing dialog with new HTML.

I also suggest to rename the plugin to "sourcedialog", which goes better with "sourcearea".

Last edited 6 years ago by Olek Nowodziński (previous) (diff)

comment:11 in reply to:  10 Changed 6 years ago by Piotrek Koszuliński

Replying to a.nowodzinski:

Still broken:

  • IE7&8 (sometimes 9):
    Permission denied  node.js, line 257 character 3
    Invalid argument.  node.js, line 563 character 4
    
    when closing dialog with new HTML.

See here https://dev.ckeditor.com/ticket/9239#comment:7 (and following comments).

comment:12 Changed 6 years ago by Olek Nowodziński

  • Updated t/9713@cksource with a fix for IE issues (comment:11) and aligned t/9713@tests-v4 to work with latest version.
  • Set tabs-size: 4 for textarea.

comment:13 Changed 6 years ago by Olek Nowodziński

Owner: changed from Frederico Caldeira Knabben to Olek Nowodziński
Status: review_failedreview

comment:14 Changed 6 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

comment:15 Changed 6 years ago by Olek Nowodziński

Plugin (+tests,+sample) should be renamed to "sourcedialog" before merging.

comment:16 Changed 6 years ago by Olek Nowodziński

Resolution: fixed
Status: review_passedclosed

Introduced new sourcedialog plugin in: git:7754ef70470365.

Sourcedialog dts are:tests 312f93b@tests-v4.

comment:17 Changed 6 years ago by Wim Leers

Awesome! :)

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy