Opened 12 years ago
Closed 12 years ago
#9882 closed Bug (fixed)
Docprops - title isn't set
Reported by: | Piotrek Koszuliński | Owned by: | Olek Nowodziński |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.0.2 |
Component: | General | Version: | 4.0 Beta |
Keywords: | Cc: |
Description (last modified by )
- Open docprops sample.
- Open docprops dialog.
- Enter a title and press ok.
- Switch to source mode - there's no title.
- Switch back to wysiwyg mode.
- Open docprops dialog - there's no title.
Everything works fine if at first title is set in source mode.
Confirmed on FF and Chrome. Similar ticket: #9168.
Change History (6)
comment:1 Changed 12 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 12 years ago by
Status: | new → confirmed |
---|---|
Version: | 4.0 → 4.0 Beta |
comment:3 Changed 12 years ago by
Owner: | set to Olek Nowodziński |
---|---|
Status: | confirmed → assigned |
comment:4 Changed 12 years ago by
Status: | assigned → review |
---|
Crated t/9882@cksource branch with a fix.
In fact the problem wasn't the docprops plugin but dataprocessor. In all browsers but IE, empty <title>
tag contains no children (text nodes). This is why 'data-cke-title'
isn't copied into <title>
tag: there's no node for such data to be copied.
The solution is basically to create such text node if there's no any. I didn't restrict this solution to !CKEDITOR.env.ie
since future versions may not insert this empty node. We can eventually change this.
Additionally crated t/9882@tests-v4 branch with basic dts for title setting and reading via docprops dialog.
comment:6 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed with git:cd289c2 on dev and ebe59d9 on tests-v4.
This can be reproduced from CKE 4 beta in Webkit, Firefox and Opera. Works fine in IE.