role="radiogroup" should be applied only to radio inputs' container.

[Irina]

To Reproduce:

1. Open any CKEditor sample in FF.
2. Open any dialog that has input fields, e.g. insert table dialog
3. Inspect input fields ( e.g. rows) using Firebug

Problem: Each inputs' container has a role="radiogroup"

Elements that use 'role' must contain required child elements for the role to enable compatibility with assistive technologies, e.g.

<div role="radiogroup">
    <div role="radio">radio element markup</div>
</div>

[Jakub Ś]

Looking at below links:

• ​http://www.w3.org/TR/wai-aria/complete#radiogroup
• ​http://www.w3.org/TR/wai-aria/complete#radio

I agree that this role should not be used on inputs as it doesn't fit to WAI definition at all.

[Marek Lewandowski]

That's correct, attr [role="radiogroup"] should not be used here. This layer is used simply as a wrapper. I've also noticed that it reuses the same label as in contained input, which also is invalid.

As a result I changed the role to presentation, and removed redundant label.

Pushed to ​t/11387 at dev.

[Piotrek Koszuliński]

Well, we should first check why the attribute was added there. I agree it looks odd there, but there might be a reason. Blame leads me to #10866. Please verify it.

[Marek Lewandowski]

I've talked with Fred and change had solely semantic purpose, since it doesn't affect JAWS. I've added the option to specify role in elementDefinition passed to CKEDITOR.ui.dialog.labeledElement, same applies to label. Both options are documented.

Pushed to ​t/11387 at dev and t/11387 at tests.

[Piotrek Koszuliński]

I rebased ​branch:t/11387 and ported tests to it.

[Olek Nowodziński]

I pushed a commit ​https://github.com/cksource/ckeditor-dev/commit/2e2e9484bf97332c32f93071bef332f14679873e that replaces RegExp-based assertions with DOM-based ones, which are much safer and straightforward.

[Piotrek Koszuliński]

Fixed on master with ​git:2974078.