Opened 11 years ago
Closed 10 years ago
#11983 closed Bug (fixed)
[Nested widgets] Clicking nested widget does not select it
| Reported by: | Piotrek Koszuliński | Owned by: | Piotrek Koszuliński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.4.2 |
| Component: | UI : Widgets | Version: | 4.3 Beta |
| Keywords: | Cc: |
Description
Part of #10931.
Since it's not yet possible to automatically initialize nested widgets, download attached sample.
Attachments (1)
Change History (6)
Changed 11 years ago by
| Attachment: | 11983.html added |
|---|
comment:1 Changed 11 years ago by
comment:2 Changed 11 years ago by
| Status: | new → confirmed |
|---|
comment:3 Changed 11 years ago by
| Owner: | set to Piotrek Koszuliński |
|---|---|
| Status: | confirmed → review |
Pushed branch:t/11983 + tests. I also create a widget/dev/nestedwidgets.html sample for manual tests.
comment:4 Changed 10 years ago by
| Status: | review → review_passed |
|---|
comment:5 Changed 10 years ago by
| Milestone: | → CKEditor 4.4.2 |
|---|---|
| Resolution: | → fixed |
| Status: | review_passed → closed |
Thanks for the thorough review. My implementation was more straightforward, but well... two times longer :D.
Fixed on master with git:cb280df on dev and 7768b55 on tests.
BTW. I think we should add also one integration test for clicking. I'll try to add one later.
Note: See
TracTickets for help on using
tickets.
Pushed branch:t/11983 with improved implementation of widgetsRepo.getByElement. It will return most inner widget and should perform much better than the previous naive implementation.
Tests and code refactorisation still needed.
PS. Remember that id may be a
'0'- case worth testing because incorrect typecasting may break the code.