Opened 11 years ago
Closed 11 years ago
#12009 closed Bug (fixed)
[Nested widgets] Integration with Magicline plugin
| Reported by: | Olek Nowodziński | Owned by: | Olek Nowodziński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.4.2 |
| Component: | General | Version: | 4.3 Beta |
| Keywords: | Cc: |
Description (last modified by )
Part of #10931.
I managed to display (and use) magicline inside of a widget but outside of a nested editable, which is unacceptable. It does not strictly concern nested widgets, but I noticed it very fast while playing with them, so that's why I consider it a related issue.
Attachments (1)
Change History (13)
Changed 11 years ago by
| Attachment: | Screen Shot 2014-05-23 at 15.26.40.png added |
|---|
comment:1 Changed 11 years ago by
| Description: | modified (diff) |
|---|
comment:2 Changed 11 years ago by
| Status: | new → confirmed |
|---|
comment:3 Changed 11 years ago by
comment:6 Changed 11 years ago by
| Owner: | set to Olek Nowodziński |
|---|---|
| Status: | confirmed → assigned |
comment:7 Changed 11 years ago by
| Status: | assigned → review |
|---|
Pushed solution and test to branch:t/12009.
comment:10 Changed 11 years ago by
| Milestone: | → CKEditor 4.4.2 |
|---|
comment:11 Changed 11 years ago by
| Status: | review → review_passed |
|---|
Remember to rearrange commits, so tests come after dev changes.
comment:12 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
git:902757f landed in master.


Magicline should be banned from including and between elements with cke_widget_editable and cke_widget_element.
To disable magicline from widget and its children one might use magicline_tabuList, but after this magicline cannot be made available within the widget.
Something of a mess that I had in my mind for solving this.. maybe some sort of deny, allow list?
data-cke-widget-wrapper: [banned,allowBefore, allowAfter], data-cke-widget-editable: [banned,allowWithin] <div>// allowed lipsum </div>// allowed <div class="cke_widget_element"> // banned, allowed add before <div class="somethingSomething"> // banned <div class="cke_widget_editable"> // banned <p> // allowed add before Widget content editable </p> //allowed add after </div> // banned </div> // banned </div> // banned, allowed add after <div> // allowed lipsum </div> // allowed