Opened 4 years ago

Closed 4 years ago

#12009 closed Bug (fixed)

[Nested widgets] Integration with Magicline plugin

Reported by: Olek Nowodziński Owned by: Olek Nowodziński
Priority: Normal Milestone: CKEditor 4.4.2
Component: General Version: 4.3 Beta
Keywords: Cc:

Description (last modified by Olek Nowodziński)

Part of #10931.

I managed to display (and use) magicline inside of a widget but outside of a nested editable, which is unacceptable. It does not strictly concern nested widgets, but I noticed it very fast while playing with them, so that's why I consider it a related issue.

Attachments (1)

Screen Shot 2014-05-23 at 15.26.40.png (160.9 KB) - added by Olek Nowodziński 4 years ago.

Download all attachments as: .zip

Change History (13)

Changed 4 years ago by Olek Nowodziński

comment:1 Changed 4 years ago by Olek Nowodziński

Description: modified (diff)

comment:2 Changed 4 years ago by Jakub Ś

Status: newconfirmed

comment:3 Changed 4 years ago by Matti Järvinen

Magicline should be banned from including and between elements with cke_widget_editable and cke_widget_element.

To disable magicline from widget and its children one might use magicline_tabuList, but after this magicline cannot be made available within the widget.

CKEDITOR.config.magicline_tabuList = [ 'data-tabu','data-cke-widget-data' ];

Something of a mess that I had in my mind for solving this.. maybe some sort of deny, allow list?

data-cke-widget-wrapper: [banned,allowBefore, allowAfter],
data-cke-widget-editable: [banned,allowWithin]

<div>// allowed
  lipsum
</div>// allowed
<div class="cke_widget_element"> // banned, allowed add before
  <div class="somethingSomething"> // banned
    <div class="cke_widget_editable"> // banned
      <p> // allowed add before
        Widget content editable
      </p> //allowed add after
    </div> // banned
  </div> // banned
</div> // banned, allowed add after
<div> // allowed
  lipsum
</div> // allowed

comment:4 Changed 4 years ago by Matti Järvinen

Related #11243

comment:5 Changed 4 years ago by Piotrek Koszuliński

cc

comment:6 Changed 4 years ago by Olek Nowodziński

Owner: set to Olek Nowodziński
Status: confirmedassigned

comment:7 Changed 4 years ago by Olek Nowodziński

Status: assignedreview

Pushed solution and test to branch:t/12009.

comment:8 Changed 4 years ago by Matti Järvinen

How can I see the commit in GitHub?

comment:9 in reply to:  8 Changed 4 years ago by Olek Nowodziński

Replying to matti:

How can I see the commit in GitHub?

https://github.com/cksource/ckeditor-dev/compare/t;12009

comment:10 Changed 4 years ago by Olek Nowodziński

Milestone: CKEditor 4.4.2

comment:11 Changed 4 years ago by Piotrek Koszuliński

Status: reviewreview_passed

Remember to rearrange commits, so tests come after dev changes.

comment:12 Changed 4 years ago by Olek Nowodziński

Resolution: fixed
Status: review_passedclosed

git:902757f landed in master.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy